Closed
Bug 349074
Opened 18 years ago
Closed 18 years ago
Mac/Intel: GenerateJavaInterfaces doesn't write constants for ifaces with no parent
Categories
(Core Graveyard :: Java to XPCOM Bridge, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: jhpedemonte)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
806 bytes,
patch
|
benjamin
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The tool GenerateJavaInterfaces doesn't write constants for interfaces that have no parent, such as gfxIFormats and nsICache. This is because TypeInfo::GetParentInfo() doesn't set |aParentConstCount| to zero when there is no parent. On PPC, it seems that the variable was defaulting to zero anyway, so this problem never arose. On Intel, the variable defaults to a random value, which causes problems.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #234306 -
Flags: review?(benjamin)
|
||
Updated•18 years ago
|
Attachment #234306 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checked into trunk. ->FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 234306 [details] [diff] [review] patch Asking for 1.8.1 branch approval. This patch only affects XULRunner.
Attachment #234306 -
Flags: approval1.8.1?
|
||
Comment 4•18 years ago
|
||
Comment on attachment 234306 [details] [diff] [review] patch a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH and mark fixed1.8.1
Attachment #234306 -
Flags: approval1.8.1? → approval1.8.1+
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•