Closed Bug 349098 Opened 14 years ago Closed 14 years ago

Text in Tabs pane is truncated when checkbox wraps

Categories

(Firefox :: Preferences, defect)

2.0 Branch
x86
Linux
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 2 beta2

People

(Reporter: LpSolit, Assigned: Waldo)

References

Details

(Keywords: fixed1.8.1)

Attachments

(2 files, 1 obsolete file)

Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1

Look at http://landfill.bugzilla.org/qa222my5/attachment.cgi?id=26 and http://landfill.bugzilla.org/qa222my5/attachment.cgi?id=25 for two screenshots of the pref panel. On the first one, the available height seems to be fixed and ignores wrapped lines. Probably it should adapt itself or at least be taller.
Flags: blocking-firefox2?
I had a chat on IRC with LpSolit and I couldn't reproduce the bug with the same system police parameters on my config. I encountered that kind of problem before and removing *.mfasl files solved it. Apparently not in that case. 
Plussing, but can we please get people trying to reproduce this? We can't ship beta 2 with a broken prefpanel ...
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: Firefox 2 → Firefox 2 beta2
Assignee: nobody → jwalden+bmo
I think this is an l10n problem.  The window size (height and width) are fully controlled by localizable preferences, and if languages require greater width to accommodate lengthy strings, they should use a greater width via the appropriate entities.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/preferences/preferences.xul&rev=1.10&root=/cvsroot&mark=77-85#73
By the way, for the first screenshot I suspect you're seeing the underlying bug which triggered bug 345572 (wrapping checkboxes screw up containing box height, at a guess), but I haven't tested to be sure.
Talking about the height, making the pref panel taller doesn't help, at least in the first URL from comment 0. The vertical space available for text doesn't adapt to match wrapped lines. Why keeping it so small?
Attached patch Hack to fix checkbox problem (obsolete) — Splinter Review
It's really either this or an entity to control height for every single checkbox in preferences, and I (and localizers, I'm sure) would rather not do that.
Attachment #234501 - Flags: review?(mconnor)
Attached patch Better hackSplinter Review
Apparently I still don't know enough about XUL.
Attachment #234501 - Attachment is obsolete: true
Attachment #234506 - Flags: review?(mconnor)
Attachment #234501 - Flags: review?(mconnor)
Comment on attachment 234506 [details] [diff] [review]
Better hack

That'll work, ship it!
Attachment #234506 - Flags: review?(mconnor)
Attachment #234506 - Flags: review+
Attachment #234506 - Flags: approval1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
Checked in branch/trunk.  The width issue should be something localizers should handle as needed.
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Summary: The pref panel isn't wide enough and the text is truncated → Text in Tabs pane is truncated when checkbox wraps
Whiteboard: [checkin needed (1.8 branch)]
Depends on: 349343
The UI is fine with:
Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1b2) Gecko/20060821 BonEcho/2.0b2

I know this fix is responsible for bug 349343, but this particular issue is fixed. Marking VERIFIED.
Status: RESOLVED → VERIFIED
Depends on: 394299
Depends on: 283697
No longer depends on: 394299
You need to log in before you can comment on or make changes to this bug.