349098 - Text in Tabs pane is truncated when checkbox wraps

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Frédéric Buclin]

Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1

Look at http://landfill.bugzilla.org/qa222my5/attachment.cgi?id=26 and http://landfill.bugzilla.org/qa222my5/attachment.cgi?id=25 for two screenshots of the pref panel. On the first one, the available height seems to be fixed and ignores wrapped lines. Probably it should adapt itself or at least be taller.

Comment 1

[Cédric Corazza]

I had a chat on IRC with LpSolit and I couldn't reproduce the bug with the same system police parameters on my config. I encountered that kind of problem before and removing *.mfasl files solved it. Apparently not in that case. 

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Plussing, but can we please get people trying to reproduce this? We can't ship beta 2 with a broken prefpanel ...

Comment 3

[Jeff Walden [:Waldo]]

I think this is an l10n problem.  The window size (height and width) are fully controlled by localizable preferences, and if languages require greater width to accommodate lengthy strings, they should use a greater width via the appropriate entities.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/preferences/preferences.xul&rev=1.10&root=/cvsroot&mark=77-85#73

Comment 4

[Jeff Walden [:Waldo]]

By the way, for the first screenshot I suspect you're seeing the underlying bug which triggered bug 345572 (wrapping checkboxes screw up containing box height, at a guess), but I haven't tested to be sure.

Comment 5

[Frédéric Buclin]

Talking about the height, making the pref panel taller doesn't help, at least in the first URL from comment 0. The vertical space available for text doesn't adapt to match wrapped lines. Why keeping it so small?

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Hack to fix checkbox problem

It's really either this or an entity to control height for every single checkbox in preferences, and I (and localizers, I'm sure) would rather not do that.

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Screenshot of hack in action

Comment 8

[Jeff Walden [:Waldo]]

Attachment: Better hack

Apparently I still don't know enough about XUL.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 234506 [details] [diff] [review]
Better hack

That'll work, ship it!

Comment 10

[Jeff Walden [:Waldo]]

Checked in branch/trunk.  The width issue should be something localizers should handle as needed.

Comment 11

[Frédéric Buclin]

The UI is fine with:
Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1b2) Gecko/20060821 BonEcho/2.0b2

I know this fix is responsible for bug 349343, but this particular issue is fixed. Marking VERIFIED.