394299 - UI to provide access to extension options from app options cut off

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Steve England [:stevee]]

Attachment: Note the bottom of the pane; UI cut off

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007083003 Minefield/3.0a8pre ID:2007083003

After landing of bug 384956, the UI falls off the bottom of the options pane for me. (Win2k, default theme, new profile). See attached image.

Comment 1

[aja+bugzilla]

Same sort of clipping occurs with XP default theme, too.

Comment 2

[AKIHIRO Misaki (a.k.a Kuden)]

This is Bug 283697.
Target Milestone: Firefox 3 M9
https://bugzilla.mozilla.org/show_bug.cgi?id=283697#c180

Comment 3

[Peter van der Woude [:Peter6]]

(In reply to comment #2)
> This is Bug 283697.
> Target Milestone: Firefox 3 M9
> https://bugzilla.mozilla.org/show_bug.cgi?id=283697#c180
> 

No it isn't so don't dupe this one to it.
And don't count on 283697 to be fixed in 3M9 either.

Comment 4

[Robert Strong (they/them - no direct email)]

taking

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch - use a containing box with 1px bottom padding

mano, this is a different approach to fixing essentially the same bug that added the height via a locale file for Bug 345572.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: screenshots with patch applied

Comment 7

[Asaf Romano (gone)]

Comment on attachment 279054 [details] [diff] [review]
patch - use a containing box with 1px bottom padding

r=mano, please file a bug for the underlying issue.

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Checking in mozilla/browser/components/preferences/main.xul;
/cvsroot/mozilla/browser/components/preferences/main.xul,v  <--  main.xul
new revision: 1.15; previous revision: 1.14
done
Checking in mozilla/browser/components/preferences/security.xul;
/cvsroot/mozilla/browser/components/preferences/security.xul,v  <--  security.xul
new revision: 1.19; previous revision: 1.18
done
Checking in mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.dtd,v  <--  preferences.dtd
new revision: 1.8; previous revision: 1.7
done
Checking in mozilla/browser/themes/winstripe/browser/preferences/preferences.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/preferences/preferences.css,v  <--  preferences.css
new revision: 1.18; previous revision: 1.17
done

Comment 9

[Robert Strong (they/them - no direct email)]

Filed Bug 394433 for the underlying issue.

Comment 10

[Robert Strong (they/them - no direct email)]

Reopening... the hourly build still exhibits problems while my own build does not.

Comment 11

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007083103 Minefield/3.0a8pre ID:2007083103
Hmm. WFM with the above build.

Comment 12

[Robert Strong (they/them - no direct email)]

I got the wrong build and with how much the prefpanes have been a PITA I assumed the worst. Glad to hear it worked.

Resolving -> Fixed.

Comment 13

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007083103 Minefield/3.0a8pre ID:2007083103 [20070831_0348_firefox-3.0a8pre.en-US.win32.zip]
--> VERIFIED

Comment 16

[Gerd]

But DOES NOT appear to be fixed.
Just got Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007090303 Minefield/3.0a8pre ID:2007090303
and the Add-ons area is still cut off.

Comment 17

[Gerd]

...fixed with clean profile so it's an extension issue perhaps.

Comment 18

[Alfred Kayser]

To get it completely fixed, replace in preferences.css:
.bottomBox{padding-bottom:2px}
with:
prefpane>.content-box{padding-bottom:4px}
as not not all panes have a 'bottomBox', but all do have a '.content-box'.
This ensures that all panes will not be cut off (or at least give it less chance to do so).

Note, the same fix should also be added to gnomestripe for Linux (see bug 412325).

Comment 19

[Alfred Kayser]

Note, with the change from comment #18, one can also remove the .bottomBox workaround and the hack in preferences.xml (lines 830-843).
The other hack (XXX rstrong) is however a valid 'hack' to ensure that the pane/window grows when the content doesn't fit the initial fixed window size.

Comment 20

[Robert Strong (they/them - no direct email)]

I highly suspect that just lessens the likelihood of this happening by increasing the padding and applying to all prefpanes vs. the ones that actually have this bug. Whatever the case bug 394433 is for fixing the underlying issue that causes this bug which should remove the .bottomBox hack and not require any other hack.

If you'd like to try to fix the underlying bug that causes this please do so in bug 394433. If you'd like to try a different hack please file a new bug.