Closed Bug 349159 Opened 15 years ago Closed 15 years ago

Add url formatter items to SeaMonkey installers.

Categories

(SeaMonkey :: Installer, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 347944 introduced a url formatter to toolkit, but only added the items to ff's installer. As it is in toolkit and built for everyone, we need to include it in the SeaMonkey installers for when we are a toolkit app.
This adds the missing unix item definitions, os2 definitions are contained within bug 332203, windows definitions will be included in the patch that's being done for the windows installer for suiterunner.
Attachment #234454 - Flags: review?(ajschult)
Comment on attachment 234454 [details] [diff] [review]
Add missing options for unix packages

Bug 347944 got the xpt name wrong :-( new patch coming up.
Attachment #234454 - Attachment is obsolete: true
Attachment #234454 - Flags: review?(ajschult)
Corrected the unix patch for the xpt name and added in the change for the os2 packager (as I'd already done the os2 on bug 332203).
Attachment #234565 - Flags: review?(ajschult)
Attachment #234565 - Flags: review?(ajschult) → review+
Attachment #234565 - Attachment description: Fix unix and os2 packaging lists → Fix unix and os2 packaging lists (checked in).
btw I'm leaving this open until we've fixed up the windows installer (probably to use nsis) just in case we forget to add these items (note xpfe doesn't need these).
Blocks: 351152
suiterunner is currently planning on using the NSIS installer - However, just in case we decide to required urlformatter on xpfe builds (as bug 351152 may do), and so we can close out this bug, I'd like to add it to the windows packaging lists anyway as it won't actually harm anything to have it in the lists but not present.
Attachment #240275 - Flags: superreview?(neil)
Attachment #240275 - Flags: review?(neil)
Comment on attachment 240275 [details] [diff] [review]
Add to windows packaging lists (checked in)

Doesn't this need to be done for other platforms too? (check with ajschult?)
Attachment #240275 - Flags: superreview?(neil)
Attachment #240275 - Flags: superreview+
Attachment #240275 - Flags: review?(neil)
Attachment #240275 - Flags: review+
(In reply to comment #6)
> (From update of attachment 240275 [details] [diff] [review] [edit])
> Doesn't this need to be done for other platforms too? (check with ajschult?)

See the first patch on this bug - that has already done unix & os2 as they will still be used for suiterunner.
Comment on attachment 240275 [details] [diff] [review]
Add to windows packaging lists (checked in)

/cvsroot/mozilla/xpinstall/packager/packages-win,v  <--  packages-win
new revision: 1.309; previous revision: 1.308
done
Attachment #240275 - Attachment description: Add to windows packaging lists → Add to windows packaging lists (checked in)
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.