349197 - calendar shouldn't use sheet for about dialog

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Josh Aas]

Calendar shouldn't use a sheet for the about dialog. Calendar version of bug 222364.

Comment 1

[Matthew (lilmatt) Willis]

Attachment: rev0 - ports fixes to Sunbird

Moves "openAboutDialog" to Sunbird-only applicationUtils.js since we don't need it on Lightning.

Comment 2

[Matthew (lilmatt) Willis]

Attachment: rev1 - fixes typo and keyset

Fixes per IRC discussion with josh

Comment 3

[Joey Minta]

Comment on attachment 234463 [details] [diff] [review]
rev1 - fixes typo and keyset

Can you elaborate on what the 'previous changes from IRC' were?  Why are we now touching a keyset in the main window?

Comment 4

[Matthew (lilmatt) Willis]

(In reply to comment #3)
> (From update of attachment 234463 [details] [diff] [review] [edit])
> Can you elaborate on what the 'previous changes from IRC' were?  Why are we now
> touching a keyset in the main window?

The main window's keyset is missing an id.
In order for us (and conceivably extensions I guess) to add or override keys in that keyset, it needs an id.

Comment 5

[Joey Minta]

(In reply to comment #4)
> The main window's keyset is missing an id.
> In order for us (and conceivably extensions I guess) to add or override keys in
> that keyset, it needs an id.
> 

That's all true but what does it have to do with a mac sheet?

Comment 6

[Joey Minta]

I just checked.  The id of the keyset in the about window has no relation to the keyset id in the main window.  I can define either to be whatever I want and it works fine for me.

Comment 7

[Matthew (lilmatt) Willis]

(In reply to comment #6)
> I just checked.  The id of the keyset in the about window has no relation to
> the keyset id in the main window.  I can define either to be whatever I want
> and it works fine for me.

Good sleuthing.
I must've jumped to a conclusion regarding needing to align the keyset ids.

So review the rev 1 patch, without the change to calendar-sets.inc. That doesn't need to be checked in.

Comment 8

[Joey Minta]

Comment on attachment 234447 [details] [diff] [review]
rev0 - ports fixes to Sunbird

r2=jminta here.

Comment 9

[Joey Minta]

rev0 checked in.