Closed Bug 349197 Opened 14 years ago Closed 14 years ago

calendar shouldn't use sheet for about dialog

Categories

(Calendar :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jaas, Assigned: mattwillis)

References

Details

Attachments

(1 file, 1 obsolete file)

Calendar shouldn't use a sheet for the about dialog. Calendar version of bug 222364.
Attached patch rev0 - ports fixes to Sunbird (obsolete) — Splinter Review
Moves "openAboutDialog" to Sunbird-only applicationUtils.js since we don't need it on Lightning.
Attachment #234447 - Flags: second-review?(jminta)
Attachment #234447 - Flags: first-review?(joshmoz)
Fixes per IRC discussion with josh
Assignee: joshmoz → mattwillis
Attachment #234447 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #234463 - Flags: second-review?(jminta)
Attachment #234463 - Flags: first-review?(joshmoz)
Attachment #234447 - Flags: second-review?(jminta)
Attachment #234447 - Flags: first-review?(joshmoz)
Attachment #234463 - Flags: first-review?(joshmoz) → first-review+
Comment on attachment 234463 [details] [diff] [review]
rev1 - fixes typo and keyset

Can you elaborate on what the 'previous changes from IRC' were?  Why are we now touching a keyset in the main window?
(In reply to comment #3)
> (From update of attachment 234463 [details] [diff] [review] [edit])
> Can you elaborate on what the 'previous changes from IRC' were?  Why are we now
> touching a keyset in the main window?

The main window's keyset is missing an id.
In order for us (and conceivably extensions I guess) to add or override keys in that keyset, it needs an id.

(In reply to comment #4)
> The main window's keyset is missing an id.
> In order for us (and conceivably extensions I guess) to add or override keys in
> that keyset, it needs an id.
> 

That's all true but what does it have to do with a mac sheet?
I just checked.  The id of the keyset in the about window has no relation to the keyset id in the main window.  I can define either to be whatever I want and it works fine for me.
(In reply to comment #6)
> I just checked.  The id of the keyset in the about window has no relation to
> the keyset id in the main window.  I can define either to be whatever I want
> and it works fine for me.

Good sleuthing.
I must've jumped to a conclusion regarding needing to align the keyset ids.

So review the rev 1 patch, without the change to calendar-sets.inc. That doesn't need to be checked in.
Comment on attachment 234447 [details] [diff] [review]
rev0 - ports fixes to Sunbird

r2=jminta here.
Attachment #234447 - Flags: second-review+
rev0 checked in.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #234463 - Flags: second-review?(jminta)
Depends on: 350310
You need to log in before you can comment on or make changes to this bug.