Closed
Bug 349220
Opened 18 years ago
Closed 18 years ago
Move SeaMonkey browser chrome to suite/
Categories
(SeaMonkey :: Build Config, defect)
SeaMonkey
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(2 files, 1 obsolete file)
5.49 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
18.64 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
This is the next episode of the SeaMonkey chrome consolidation in the suite/ directory: Now it's time to get browser chrome over there.
Patch following soon...
Assignee | ||
Comment 1•18 years ago
|
||
BTW, I'm also planning to remove navExtraOverlay while I'm at it, as this one is completely empty (presumably it's been there for Netscape only).
Assignee | ||
Comment 2•18 years ago
|
||
This is the cvs copy file for this move, I have roughly tested it by feeding it to mcp and it did the right thing (and found all files to copy).
Attachment #234488 -
Flags: superreview?(neil)
Attachment #234488 -
Flags: review?(neil)
Assignee | ||
Comment 3•18 years ago
|
||
This is the jar.mn patch for building the files from suite/ instead of xpfe/ - this removes xpfe/browser/jar.mn (which is suite-only) and also patches navigator.xul to not use the omitted overlay (be sure to have copied it before so the patch applies).
I still need to test if it works correctly with both xpfe-based suite and suiterunner.
Attachment #234489 -
Flags: superreview?(neil)
Attachment #234489 -
Flags: review?(neil)
Assignee | ||
Comment 4•18 years ago
|
||
Comment on attachment 234489 [details] [diff] [review]
jar.mn patch for moving
This does not work yet like I'd want it to. Apart from a small error in a jar.mn, we also need some Makefile changes.
Attachment #234489 -
Attachment is obsolete: true
Attachment #234489 -
Flags: superreview?(neil)
Attachment #234489 -
Flags: review?(neil)
Assignee | ||
Comment 5•18 years ago
|
||
OK, here's a patch that is tested to work and really makes us build the browser UI from suite/ for both xpfe suite and suiterunner.
Attachment #234513 -
Flags: superreview?(neil)
Attachment #234513 -
Flags: review?(neil)
Comment 6•18 years ago
|
||
Comment on attachment 234513 [details] [diff] [review]
build browser chrome from suite/
>+* content/navigator-platform/contents.rdf (contents-platform.rdf)
Note that for some reason the current contents-platform.rdf files contain platform-specific strings, so you'll need to neutralise the wording as per the version in suite/common. r+sr=me with this fixed.
Attachment #234513 -
Flags: superreview?(neil)
Attachment #234513 -
Flags: superreview+
Attachment #234513 -
Flags: review?(neil)
Attachment #234513 -
Flags: review+
Updated•18 years ago
|
Attachment #234488 -
Flags: superreview?(neil)
Attachment #234488 -
Flags: superreview+
Attachment #234488 -
Flags: review?(neil)
Attachment #234488 -
Flags: review+
Assignee | ||
Comment 7•18 years ago
|
||
Checked in, and cvs removed all files from xpfe/browser/resources as that content has all moved now to suite/
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•