Closed Bug 349233 Opened 18 years ago Closed 18 years ago

feed subscription ui not functional after going back to the preview page

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Version:
2.0 Branch
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: rOmAz, Assigned: asaf)

References

Details

(Keywords: fixed1.8.1, relnote)

Attachments

(1 file)

Disable bfcache for feed preview
1.48 KB, patch
mconnor
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060817 BonEcho/2.0b1

after choosing a feed reader for a rss feed,
i pressed the back button on my browser.
when i tried to select a different feed reader,
the subscribe now button didnt function at all.
also, the text near the subscribe button doesnt change.

Reproducible: Always

Steps to Reproduce:
1. open feed
2. press subscribe using live bookmarks
3. press the back button
4. choose different feed reader
5. press subscribe now

Actual Results:  
cant change feed reader


none
Assignee: nobody → bugs.mano
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-firefox2?
Summary: feed subscription ui unfunctional after pressing the back button → feed subscription ui not functional after going back to the preview page
Target Milestone: --- → Firefox 2
Blocks: 346009
Status: NEW → ASSIGNED
OS: Windows XP → All
Priority: -- → P1
Hardware: PC → All
Version: unspecified → 2.0 Branch

        Attachment #234617 -
        Flags: review?(mconnor)

        Attachment #234617 -
        Flags: approval1.8.1?

    
  
Target Milestone: Firefox 2 → Firefox 2 beta2
Flags: blocking-firefox2? → blocking-firefox2+
Keywords: relnote
Target Milestone: Firefox 2 beta2 → Firefox 2

    
    

    
  
Comment on attachment 234617 [details] [diff] [review]
Disable bfcache for feed preview

Please get r+ and on trunk before nominating approval.

        Attachment #234617 -
        Flags: approval1.8.1?
Whiteboard: [has patch][needs review mconnor]

    
    

    
  
Comment on attachment 234617 [details] [diff] [review]
Disable bfcache for feed preview

r=me, looks safe and straightforward, plus a bit of cleanup from previous patches.

        Attachment #234617 -
        Flags: review?(mconnor) → review+

    
  
Whiteboard: [has patch][needs review mconnor] → [has patch]

    
  

        Attachment #234617 -
        Flags: approval1.8.1?

    
    

    
  
trunk:
Checking in browser/components/feeds/content/subscribe.js;
/cvsroot/mozilla/browser/components/feeds/content/subscribe.js,v  <--  subscribe.js
new revision: 1.12; previous revision: 1.11
done
Checking in browser/components/feeds/content/subscribe.xhtml;
/cvsroot/mozilla/browser/components/feeds/content/subscribe.xhtml,v  <--  subscribe.xhtml
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 234617 [details] [diff] [review]
Disable bfcache for feed preview

a=beltzner on behalf of the 181drivers

        Attachment #234617 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
1.8 branch:
mozilla/browser/components/feeds/content/subscribe.js 1.1.2.9
mozilla/browser/components/feeds/content/subscribe.xhtml 1.1.2.11
Keywords: fixed1.8.1
Whiteboard: [has patch]

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: