Closed
Bug 349603
Opened 19 years ago
Closed 19 years ago
Show the same installation UI for extensions and themes.
Categories
(Core Graveyard :: Installer: XPInstall Engine, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [no l10n impact])
Attachments
(1 file)
|
2.66 KB,
patch
|
dveditz
:
review+
mconnor
:
review+
dveditz
:
superreview+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
See bug 343037 comment 31 and bug 343037 comment 35. We're going to do this at least until we figure how whether and how to fix bug 343037
|
Assignee | |
Comment 1•19 years ago
|
||
s/how whether/whether
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Priority: -- → P1
Whiteboard: no l10n impact
|
||
Comment 2•19 years ago
|
||
Core -> Installer XPInstall Engine
Component: Extension/Theme Manager → Installer: XPInstall Engine
Flags: blocking-firefox2?
Product: Firefox → Core
QA Contact: extension.manager → xpi-engine
Target Milestone: Firefox 2 → ---
Version: unspecified → 1.8 Branch
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.8.1?
Target Milestone: --- → mozilla1.8.1
|
||
Updated•19 years ago
|
Flags: blocking1.8.1? → blocking1.8.1+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Attachment #235008 -
Flags: superreview?(dveditz)
Attachment #235008 -
Flags: review?(dveditz)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: no l10n impact → [no l10n impact][needs review dveditz]
|
||
Comment 4•19 years ago
|
||
Comment on attachment 235008 [details] [diff] [review]
patch
r/sr=dveditz on the code if UI-people like beltzner and mconnor are OK with this change.
Attachment #235008 -
Flags: superreview?(dveditz)
Attachment #235008 -
Flags: superreview+
Attachment #235008 -
Flags: review?(dveditz)
Attachment #235008 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #235008 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [no l10n impact][needs review dveditz] → [no l10n impact][needs review dveditz][needs review mconnor]
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [no l10n impact][needs review dveditz][needs review mconnor] → [no l10n impact][needs review mconnor]
|
|
||
Comment 5•19 years ago
|
||
Comment on attachment 235008 [details] [diff] [review]
patch
Yeah, we're totally looking for this for branch.
Attachment #235008 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #235008 -
Flags: approval1.8.1?
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [no l10n impact][needs review mconnor] → [no l10n impact]
|
|
||
Comment 6•19 years ago
|
||
has this landed on trunk - not seeing it on bonsai...
|
|
||
Updated•19 years ago
|
Whiteboard: [no l10n impact] → [land on trunk[[no l10n impact]
|
|
Assignee | |
Comment 7•19 years ago
|
||
mozilla/xpinstall/src/nsXPInstallManager.cpp 1.147
mozilla/xpinstall/src/nsXPInstallManager.h 1.41
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [land on trunk[[no l10n impact] → [no l10n impact]
|
|
||
Updated•19 years ago
|
Whiteboard: [no l10n impact] → [baking until 8/29][no l10n impact]
|
|
||
Comment 8•19 years ago
|
||
Comment on attachment 235008 [details] [diff] [review]
patch
a=schrep/beltnzer for drivers.
Attachment #235008 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Updated•19 years ago
|
Whiteboard: [baking until 8/29][no l10n impact] → [no l10n impact]
|
|
Assignee | |
Comment 9•19 years ago
|
||
1.8 branch:
mozilla/xpinstall/src/nsXPInstallManager.cpp 1.135.2.7
mozilla/xpinstall/src/nsXPInstallManager.h 1.39.18.2
Keywords: fixed1.8.1
|
||
Updated•10 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•