Closed
Bug 349614
Opened 19 years ago
Closed 19 years ago
New theme shouldn't use rtl images in Pinstripe
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: philor, Assigned: philor)
References
()
Details
(Keywords: fixed1.8.1, rtl, Whiteboard: [Fx2 theme change])
Attachments
(2 files)
|
16.05 KB,
image/png
|
Details | |
|
4.85 KB,
patch
|
asaf
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Current state with rtl chrome
Mano says the CSS should go out, rather than the image going in.
|
Assignee | |
Comment 1•19 years ago
|
||
Ah, more than just livemark, there's also Go-rtl.png and a couple of search things, where the image exists, but shouldn't be used/packaged.
Component: RSS Discovery and Preview → Toolbars
QA Contact: rss.preview → toolbars
Summary: [Mac] New theme tries to use livemark-item-rtl.png, which doesn't exist → New theme shouldn't use rtl images in Pinstripe
|
|
Assignee | |
Comment 2•19 years ago
|
||
|
|
Assignee | |
Comment 3•19 years ago
|
||
Seems to cover it, for an rtl en-US.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #234902 -
Flags: review?(bugs.mano)
|
||
Comment 4•19 years ago
|
||
Comment on attachment 234902 [details] [diff] [review]
Fix v.1
r=mano.
Attachment #234902 -
Flags: review?(bugs.mano)
Attachment #234902 -
Flags: review+
Attachment #234902 -
Flags: approval1.8.1?
|
|
Assignee | |
Updated•19 years ago
|
|
||
Updated•19 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: --- → Firefox 2
|
|
||
Updated•19 years ago
|
Whiteboard: [Fx2 theme change] → [Fx2 theme change][181approval pending]
|
||
Comment 5•19 years ago
|
||
Comment on attachment 234902 [details] [diff] [review]
Fix v.1
a=schrep for drivers - approving all [181approval pending] bugs now that tree is open.
Attachment #234902 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [Fx2 theme change][181approval pending] → [Fx2 theme change]
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [Fx2 theme change] → [Fx2 theme change][checkin needed (1.8branch)]
|
||
Comment 6•19 years ago
|
||
mozilla/browser/themes/pinstripe/browser/jar.mn 1.12.2.19
mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.30
mozilla/browser/themes/pinstripe/browser/searchbar.css 1.4.8.11
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][checkin needed (1.8branch)] → [Fx2 theme change]
|
||
Comment 7•19 years ago
|
||
If I set bidi-direction to 2, the Mac Fx 2.0 20060825 build looks pretty much like the screenshot in comment 2. Tab chrome is all mixed up, too. Is this still supposed to be the case? Maybe it's because my OS is still ltr, or because I'm using an ltr lanuage in the browser?
|
||
Comment 8•19 years ago
|
||
I've been testing with locale.dir "rtl" in global.dtd and :root { direction: ltr } in userChrome.css. With those, the images and CSS are both needed. Clearly I'm confused about what pinstripe does for RTL.
So does pinstripe not use RTL chrome at all, meaning I shouldn't worry about it in bug 348138 either?
|
|
||
Comment 9•19 years ago
|
||
(In reply to comment #8)
> So does pinstripe not use RTL chrome at all, meaning I shouldn't worry about it
> in bug 348138 either?
That's correct, Pinstripe currently does not support RTL.
|
||
Comment 10•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•