freebl libraries are always optimized on Sparc

RESOLVED FIXED in 3.11.3

Status

P2
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: julien.pierre, Assigned: julien.pierre)

Tracking

3.11.2
3.11.3
Sun
SunOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Currently, the freebl libraries are always optimized on Ultrasparc, even in our debug builds. This is because the optimizer flags were added to the SOL_CFLAGS gmake variable, which is used for both debug and optimized builds.
(Assignee)

Updated

12 years ago
Priority: -- → P2
Target Milestone: --- → 3.11.3
(Assignee)

Comment 1

12 years ago
*** Bug 349928 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 2

12 years ago
Created attachment 235153 [details] [diff] [review]
Only use optimizer flags if BUILD_OPT is set . Also delete -fns which has no effect
Attachment #235153 - Flags: superreview?(nelson)
Attachment #235153 - Flags: review?(neil.williams)

Comment 3

12 years ago
Comment on attachment 235153 [details] [diff] [review]
Only use optimizer flags if BUILD_OPT is set . Also delete -fns which has no effect

Looks good. I wonder what -xdepend (no argument) defaults to.
Attachment #235153 - Flags: review?(neil.williams) → review+
Comment on attachment 235153 [details] [diff] [review]
Only use optimizer flags if BUILD_OPT is set . Also delete -fns which has no effect

r=nelson
Attachment #235153 - Flags: superreview?(nelson) → review+
(Assignee)

Comment 5

12 years ago
Thanks for the quick reviews to both of you.

-xdepend is set to no by default . It is dangerous, because setting it automatically raises optimization level to -xO3, so it definitely needs to be left off in the debug build .

I checked in this patch to the tip :

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/Makefile,v  <--  Makefile
new revision: 1.86; previous revision: 1.85
done

And to NSS_3_11_BRANCH :

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/Makefile,v  <--  Makefile
new revision: 1.70.2.11; previous revision: 1.70.2.10
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.