349920 - freebl libraries are always optimized on Sparc

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

Currently, the freebl libraries are always optimized on Ultrasparc, even in our debug builds. This is because the optimizer flags were added to the SOL_CFLAGS gmake variable, which is used for both debug and optimized builds.

Comment 1

[Julien Pierre]

*** Bug 349928 has been marked as a duplicate of this bug. ***

Comment 2

[Julien Pierre]

Attachment: Only use optimizer flags if BUILD_OPT is set . Also delete -fns which has no effect

Comment 3

[Neil Williams]

Comment on attachment 235153 [details] [diff] [review]
Only use optimizer flags if BUILD_OPT is set . Also delete -fns which has no effect

Looks good. I wonder what -xdepend (no argument) defaults to.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 235153 [details] [diff] [review]
Only use optimizer flags if BUILD_OPT is set . Also delete -fns which has no effect

r=nelson

Comment 5

[Julien Pierre]

Thanks for the quick reviews to both of you.

-xdepend is set to no by default . It is dangerous, because setting it automatically raises optimization level to -xO3, so it definitely needs to be left off in the debug build .

I checked in this patch to the tip :

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/Makefile,v  <--  Makefile
new revision: 1.86; previous revision: 1.85
done

And to NSS_3_11_BRANCH :

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/freebl/Makefile,v  <--  Makefile
new revision: 1.70.2.11; previous revision: 1.70.2.10
done