349956 - Decompiler can't make up its mind for <x/>.@*

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

> function () { <x/>.@* }
function () { <x/>[@[*]]; }

> function () { <x/>[@[*]]; }
function () { <x/>.@[*]; }

The fact that it takes more than 1 trip through uneval to settle on a final form confuses my fuzzer in bug 349611.

> function () { <x/>.@[*]; }
function () { <x/>[@[*]]; }

The fact that it *never* settles on a final form (bouncing back and forth between two forms) bothers me even more.

These aren't necessarily bugs, but they do interfere with certain methods of testing decompilation.

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

Need shaver to sub for mrbkap while mrbkap drives back to Rice via L.A.

/be

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Shaver, please renom for 181 assuming this passes your review. Also, be sure to tell us how it feels to be the new mrbkap!

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 235177 [details] [diff] [review]
fix

r=shaver.

I was the old mrbkap before mrbkap was the new mrbkap.

Comment 4

[Brendan Eich [:brendan]]

Fixed on trunk.

Checking in jsopcode.c;
/cvsroot/mozilla/js/src/jsopcode.c,v  <--  jsopcode.c
new revision: 3.146; previous revision: 3.145
done

/be

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235177 [details] [diff] [review]
fix

a=beltzner on behalf of the 181drivers

Comment 6

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 7

[Jesse Ruderman]

That fixed <x/>.@* to not go into a back-and-forth loop, but the back-and-forth loop is still there.  I filed bug 350226 for that.

Comment 8

[Bob Clary [:bc] (inactive)]

Checking in regress-349956.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-349956.js,v  <--  regress-349956.js
initial revision: 1.1

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 20060827 windows/mac*/linux

both 1.8.0.7, 1.8 agree
expected: function () {     <x/>.@*; } 
actual: function () {     <x/>.@*; }

Comment 10

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060827 windows/mac*/linux