Decompiler still can't make up its mind for <x/>.@[*]

VERIFIED FIXED in mozilla1.8.1

Status

()

P2
minor
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: jruderman, Assigned: brendan)

Tracking

(Blocks: 1 bug, {testcase, verified1.8.1})

Trunk
mozilla1.8.1
PowerPC
Mac OS X
testcase, verified1.8.1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
This is a continuation of bug 349956.

> function () { <x/>[@[*]]; }
function () { <x/>.@[*]; }

> function () { <x/>.@[*]; }
function () { <x/>[@[*]]; }
(Assignee)

Comment 1

12 years ago
(In reply to comment #0)
> This is a continuation of bug 349956.
> 
> > function () { <x/>[@[*]]; }
> function () { <x/>.@[*]; }

I get the same result:

js> function () { <x/>[@[*]]; }
function () {
    <x/>.@[*];
}

> > function () { <x/>.@[*]; }
> function () { <x/>[@[*]]; }

But I get the correct result here:

js> function () { <x/>.@[*]; }
function () {
    <x/>.@[*];
}

I'm running with the patches for bug 349650 and bug 350531.

/be
(Assignee)

Comment 2

12 years ago
Created attachment 237040 [details] [diff] [review]
fix

The JOF_XMLNAME format is as commented in jsopcode.h -- it must not apply to the JSOP_XMLNAME or derived (JSOP_(BIND|SET)XMLNAME) ops.  Those ops are used only for unqualified (that is, not preceded by the binary . or .. operators) XML names, and so if used in [] after a left operand of [], must be decompiled using [], not by converting [] to dot.

/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #237040 - Flags: review?(jwalden+bmo)

Comment 3

12 years ago
Comment on attachment 237040 [details] [diff] [review]
fix

After staring at this long enough and after taking into (heavy) consideration the previous comment, I *think* this is correct.
Attachment #237040 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 4

12 years ago
Fixed on trunk.

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

12 years ago
Comment on attachment 237040 [details] [diff] [review]
fix

This fix is a pure E4X only decompilation fix, can't break anything else, and demonstrably helps.

/be
Attachment #237040 - Flags: approval1.8.1?

Comment 6

12 years ago
Checking in regress-350226.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-350226.js,v  <--  regress-350226.js
initial revision: 1.1
Flags: in-testsuite+
Comment on attachment 237040 [details] [diff] [review]
fix

a=beltzner on behalf of 181drivers
Attachment #237040 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Updated

12 years ago
Priority: -- → P2
Target Milestone: --- → mozilla1.8.1
(Assignee)

Comment 8

12 years ago
To avoid conflicts, this patch should land after the patches for bug 350531 and its followups.

/be
Depends on: 350531
(Assignee)

Comment 9

12 years ago
Fixed on the 1.8 branch.

/be
Keywords: fixed1.8.1

Comment 10

12 years ago
verified fixed 1.9a1_2006090707 windows/mac*/linux
Status: RESOLVED → VERIFIED

Comment 11

12 years ago
verified fixed 1.8 1.9 20060909 windows/mac*/linux
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.