Closed
Bug 349973
Opened 19 years ago
Closed 18 years ago
IsSplittable() never fails so does not need to return error code
Categories
(Core :: Layout: Block and Inline, enhancement)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(1 file)
|
27.76 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
I think we should change
NS_IMETHOD IsSplittable(nsSplittableType& aIsSplittable) const;
to
nsSplittableType GetSplittableType() const;
It's only used within layout/ and always return NS_OK as far as I can see.
|
Assignee | |
Comment 1•18 years ago
|
||
Like so?
Attachment #248997 -
Flags: superreview?(bzbarsky)
Attachment #248997 -
Flags: review?(bzbarsky)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 248997 [details] [diff] [review]
Patch rev. 1
Makes sense
Attachment #248997 -
Flags: superreview?(bzbarsky)
Attachment #248997 -
Flags: superreview+
Attachment #248997 -
Flags: review?(bzbarsky)
Attachment #248997 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Checked in to trunk at 2006-12-19 19:52 PST
-> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•