916972 - NS_FRAME_SPLITTABLE_NON_RECTANGULAR is unused (which means GetSplittableType could be consolidated into IsFrameOfType?)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

NS_FRAME_SPLITTABLE_NON_RECTANGULAR is currently unused, in that we don't have any code that cares about it specifically.

This MXR search just shows two hits for the token -- one for the nsBlockFrame::GetSplittableType return value, and one for the #define...
http://mxr.mozilla.org/mozilla-central/search?string=NS_FRAME_SPLITTABLE_NON_RECTANGULAR
...but no hits for anybody checking for this value.

Unless we have plans to add code that requires NS_FRAME_SPLITTABLE_NON_RECTANGULAR, perhaps we should just merge it with NS_FRAME_SPLITTABLE?  Even better, perhaps we can remove GetSplittableType and just replace it with a single IsFrameOfType() bit?



(side-note: we actually only ever call GetSplittableType in one place, which is in a assertion that's somewhat redundant anyway, given a NS_RUNTIMEABORT slightly later in the code that will basically fire anytime the assertion would fire.)

Comment 1

[Daniel Holbert [:dholbert]]

[historical note: the last check for NS_FRAME_SPLITTABLE_NON_RECTANGULAR was removed here:
  https://hg.mozilla.org/mozilla-central/rev/a19dfdbf7fee#l3.16
]

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 916972 - Eliminate nsIFrame::GetSplittableType() completely.

Currently, GetSplittableType() is called only in
nsCSSFrameConstructor::CreateContinuingFrame(). The splittable concrete frames
should inherit from nsSplittableFrame, and must explicitly create continuing
frame in CreateContinuingFrame(). Thus, no need to maintain GetSplittableType().

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 916972 - Remove unused nsSpread and carried-out margin flags in nsIFrame.h.

Depends on D10798

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09df5390e2fb
Eliminate nsIFrame::GetSplittableType() completely. r=mats,dholbert
https://hg.mozilla.org/integration/autoland/rev/723af5c4a100
Remove unused nsSpread and carried-out margin flags in nsIFrame.h. r=dholbert

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/09df5390e2fb
https://hg.mozilla.org/mozilla-central/rev/723af5c4a100