350071 - nsISVGRendererCanvas uses non-scriptable nsISVGRendererSurface and nsPresContext

Status: RESOLVED DUPLICATE of bug 339863

(Core :: SVG, defect)

Description

[jhp (no longer active)]

Got these errors when building JavaXPCOM on the trunk:

../../../../_javagen/default/org/mozilla/xpcom/nsISVGRendererCanvas.java:35: cannot find symbol
symbol  : class nsPresContext
location: interface org.mozilla.xpcom.nsISVGRendererCanvas
  nsPresContext getPresContext();
  ^
../../../../_javagen/default/org/mozilla/xpcom/nsISVGRendererCanvas.java:83: cannot find symbol
symbol  : class nsISVGRendererSurface
location: interface org.mozilla.xpcom.nsISVGRendererCanvas
  void pushSurface(nsISVGRendererSurface surface, boolean isSubSurface);
                   ^
../../../../_javagen/default/org/mozilla/xpcom/nsISVGRendererCanvas.java:95: cannot find symbol
symbol  : class nsISVGRendererSurface
location: interface org.mozilla.xpcom.nsISVGRendererCanvas
  void compositeSurface(nsISVGRendererSurface surface, float opacity);
                        ^
../../../../_javagen/default/org/mozilla/xpcom/nsISVGRendererCanvas.java:97: cannot find symbol
symbol  : class nsISVGRendererSurface
location: interface org.mozilla.xpcom.nsISVGRendererCanvas
  void compositeSurfaceWithMask(nsISVGRendererSurface surface, nsISVGRendererSurface mask);
                                ^
../../../../_javagen/default/org/mozilla/xpcom/nsISVGRendererCanvas.java:97: cannot find symbol
symbol  : class nsISVGRendererSurface
location: interface org.mozilla.xpcom.nsISVGRendererCanvas
  void compositeSurfaceWithMask(nsISVGRendererSurface surface, nsISVGRendererSurface mask);
                                                               ^
../../../../_javagen/default/org/mozilla/xpcom/nsISVGRendererCanvas.java:99: cannot find symbol
symbol  : class nsISVGRendererSurface
location: interface org.mozilla.xpcom.nsISVGRendererCanvas
  void compositeSurfaceMatrix(nsISVGRendererSurface surface, nsIDOMSVGMatrix canvasTM, float opacity);
                              ^

The interface nsISVGRendererCanvas is set as "scriptable", but none of the other nsISVGRender* interfaces are.  So I'm thinking we should remove "scriptable" form nsISVGRendererCanvas.  What do you think, Tim?

Comment 1

[jhp (no longer active)]

Attachment: patch

Comment 2

[jhp (no longer active)]

Well, color me stupid.  Looks like I missed this one file when I checked in the patch from bug 339863.

*** This bug has been marked as a duplicate of 339863 ***