Closed Bug 350081 Opened 13 years ago Closed 13 years ago

ASSERTION: invalid number of columns

Categories

(Core :: Layout: Tables, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.8.0.7, fixed1.8.1, testcase)

Attachments

(3 files, 1 obsolete file)

see testcase
Attached file testcase
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attached patch patch (obsolete) — Splinter Review
Attachment #235281 - Flags: superreview?(bzbarsky)
Attachment #235281 - Flags: review?(bzbarsky)
Attachment #235281 - Flags: superreview?(bzbarsky)
Attachment #235281 - Flags: superreview+
Attachment #235281 - Flags: review?(bzbarsky)
Attachment #235281 - Flags: review+
Attached patch revised patchSplinter Review
The change from the previous patch also needs to be done in AppendCells.
Attachment #235281 - Attachment is obsolete: true
Attachment #235538 - Flags: superreview?(bzbarsky)
Attachment #235538 - Flags: review?(bzbarsky)
Attachment #235538 - Flags: approval1.8.1?
Boris if you could propose a better name I am happy to follow.
Comment on attachment 235538 [details] [diff] [review]
revised patch

this revises the patch for bug 347725
Attachment #235538 - Flags: approval1.8.0.7?
Comment on attachment 235538 [details] [diff] [review]
revised patch

Thanks for working on this!  Clearing 1.8.1 flags since reviews are not complete.  Please get the reviews complete, land on trunk, and then re-request 1.8.1 approval.
Attachment #235538 - Flags: approval1.8.1?
Comment on attachment 235538 [details] [diff] [review]
revised patch

>Index: nsTableFrame.cpp
>+nsTableFrame::MatchCellMapToColCache()
>+{
>+  nsTableCellMap* cellMap = GetCellMap();

Why get it up front here instead of where it's needed?

Either move this to the one spot in this function where we use it, or pass an nsTableCellMap as an arg.

r+sr=bzbarsky with that
Comment on attachment 235538 [details] [diff] [review]
revised patch

approved for 1.8.0 branch, a=dveditz for drivers with bz's comment incorporated
Attachment #235538 - Flags: approval1.8.0.7? → approval1.8.0.7+
fixed on trunk with bz comment (I went for the arg)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 235538 [details] [diff] [review]
revised patch

I would like to take this onto 1.8.1 too
Attachment #235538 - Flags: approval1.8.1?
Keywords: fixed1.8.0.7
Comment on attachment 235538 [details] [diff] [review]
revised patch

a=beltzner for 1.8.1drivers with bz's comments incorporated.
Attachment #235538 - Flags: approval1.8.1? → approval1.8.1+
fixed on 1.8.1
Keywords: fixed1.8.1
Attachment #235538 - Flags: superreview?(bzbarsky)
Attachment #235538 - Flags: superreview+
Attachment #235538 - Flags: review?(bzbarsky)
Attachment #235538 - Flags: review+
You need to log in before you can comment on or make changes to this bug.