ASSERTION: invalid number of columns

RESOLVED FIXED

Status

()

Core
Layout: Tables
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Bernd, Assigned: Bernd)

Tracking

(Blocks: 1 bug, {fixed1.8.0.7, fixed1.8.1, testcase})

Trunk
x86
Windows XP
fixed1.8.0.7, fixed1.8.1, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

11 years ago
see testcase
(Assignee)

Comment 1

11 years ago
Created attachment 235279 [details]
testcase
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 years ago
Created attachment 235281 [details] [diff] [review]
patch
Attachment #235281 - Flags: superreview?(bzbarsky)
Attachment #235281 - Flags: review?(bzbarsky)
Attachment #235281 - Flags: superreview?(bzbarsky)
Attachment #235281 - Flags: superreview+
Attachment #235281 - Flags: review?(bzbarsky)
Attachment #235281 - Flags: review+
(Assignee)

Comment 3

11 years ago
Created attachment 235537 [details]
another case where it asserts
(Assignee)

Comment 4

11 years ago
Created attachment 235538 [details] [diff] [review]
revised patch

The change from the previous patch also needs to be done in AppendCells.
Attachment #235281 - Attachment is obsolete: true
Attachment #235538 - Flags: superreview?(bzbarsky)
Attachment #235538 - Flags: review?(bzbarsky)
Attachment #235538 - Flags: approval1.8.1?
(Assignee)

Comment 5

11 years ago
Boris if you could propose a better name I am happy to follow.
(Assignee)

Comment 6

11 years ago
Comment on attachment 235538 [details] [diff] [review]
revised patch

this revises the patch for bug 347725
Attachment #235538 - Flags: approval1.8.0.7?

Comment 7

11 years ago
Comment on attachment 235538 [details] [diff] [review]
revised patch

Thanks for working on this!  Clearing 1.8.1 flags since reviews are not complete.  Please get the reviews complete, land on trunk, and then re-request 1.8.1 approval.
Attachment #235538 - Flags: approval1.8.1?
Comment on attachment 235538 [details] [diff] [review]
revised patch

>Index: nsTableFrame.cpp
>+nsTableFrame::MatchCellMapToColCache()
>+{
>+  nsTableCellMap* cellMap = GetCellMap();

Why get it up front here instead of where it's needed?

Either move this to the one spot in this function where we use it, or pass an nsTableCellMap as an arg.

r+sr=bzbarsky with that
Comment on attachment 235538 [details] [diff] [review]
revised patch

approved for 1.8.0 branch, a=dveditz for drivers with bz's comment incorporated
Attachment #235538 - Flags: approval1.8.0.7? → approval1.8.0.7+
(Assignee)

Comment 10

11 years ago
fixed on trunk with bz comment (I went for the arg)
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

11 years ago
Comment on attachment 235538 [details] [diff] [review]
revised patch

I would like to take this onto 1.8.1 too
Attachment #235538 - Flags: approval1.8.1?
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.7
Comment on attachment 235538 [details] [diff] [review]
revised patch

a=beltzner for 1.8.1drivers with bz's comments incorporated.
Attachment #235538 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 13

11 years ago
fixed on 1.8.1
Keywords: fixed1.8.1
Attachment #235538 - Flags: superreview?(bzbarsky)
Attachment #235538 - Flags: superreview+
Attachment #235538 - Flags: review?(bzbarsky)
Attachment #235538 - Flags: review+
You need to log in before you can comment on or make changes to this bug.