Closed Bug 347725 Opened 18 years ago Closed 18 years ago

Crash [@ nsTableRowFrame::CollapseRowIfNecessary]

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jruderman, Assigned: bernd_mozilla)

References

Details

(4 keywords)

Crash Data

Attachments

(2 files)

testcase
675 bytes, application/xhtml+xml
Details
don't assert but fix it
1.28 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060806 Minefield/3.0a1

Loading the testcase makes Firefox crash [@ nsTableRowFrame::CollapseRowIfNecessary].
Attached file testcase — 

    
    

    
  
Crashed also on Win xp with this build:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060806 Minefield/3.0a1
Changing to ALL\ALL
OS: Mac OS X 10.4 → All
Hardware: Macintosh → All

    
    

    
  
This regressed between 2006-08-04 and 2006-08-06, so very likely a regression from bug 343087.
Blocks: 343087, 346980

    
  
Assignee: nobody → bernd_mozilla

    
    

    
  


  

        Attachment #234841 -
        Flags: superreview?(bzbarsky)

        Attachment #234841 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 234841 [details] [diff] [review]
don't assert but fix it

OK, makes sense

        Attachment #234841 -
        Flags: superreview?(bzbarsky)

        Attachment #234841 -
        Flags: superreview+

        Attachment #234841 -
        Flags: review?(bzbarsky)

        Attachment #234841 -
        Flags: review+

    
    

    
  
fix checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Flags: blocking1.8.0.8?

    
    

    
  
Verified FIXED with the testcase at https://bugzilla.mozilla.org/attachment.cgi?id=232521 using trunk build 2006-08-25-09 of SeaMonkey under Windows XP; no crash.
Status: RESOLVED → VERIFIED

    
    

    
  
the patch here is will not go onto branch but the more correct patch in bug 350081

    
    

    
  
fixed on branches by the cellmap branch patch
Keywords: fixed1.8.0.7, 
          
            fixed1.8.1

    
    

    
  
Testcase does not crash on branches, but I can verify that it still does not crash.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2

verifed 1.8.1

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060906 Firefox/1.5.0.7

verified 1.8.0.7
Keywords: fixed1.8.0.7, 
          
            fixed1.8.1 → verified1.8.0.7, 
          
            verified1.8.1

    
    

    
  
Restoring lost blocking flag
Flags: blocking1.8.0.9?

    
    

    
  
no need to block for 1.8.0.9, this got already fixed on the branch see comment 8 and comment 9

    
  
Flags: blocking1.8.0.9?

    
    

    
  
Crashtest checked in.
Flags: in-testsuite+
Crash Signature: [@ nsTableRowFrame::CollapseRowIfNecessary]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: