350161 - very difficult the selecting URL text and drag to tab bar for opening

Status: RESOLVED DUPLICATE of bug 138245

(Firefox :: Tabbed Browser, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See the test case:
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=3292

In the first paragraph, the br elements are on the tail of the line in source code. This is generally style. We can open the url easily by selecting a line and dragging the selection and dropping to tabber.

But in the second paragraph, the br elements are on the head of the line in source code. This is not a generally style, maybe. But some dynamic contents may use this style. In this case we cannot open the url easily by D&D.

I'll create the patch.

Comment 1

[Uri Bernstein]

This WFM on:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060824 Minefield/3.0a1

I can triple-click on any of the URLs in the testcase (including the three on the bottom), and drag them into the URL bar, and the browser navigates as expected.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hey, Uri, please drop *tab bar* or *tab*.

Comment 3

[Uri Bernstein]

(In reply to comment #2)
> Hey, Uri, please drop *tab bar* or *tab*.
> 

Sorry - my bad. When dropping to the tab bar (or tab) I do see the problem.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

This patch trims the space of the URL.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 235409 [details] [diff] [review]
Patch rv1.0

Oops, sorry. The patch is not for this bug.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Comment 7

[[e-mail]]

(In reply to comment #3)
>When dropping to the tab bar (or tab) I do see the problem.
So should we be selecting the (invisible) trailing space?
We don't select invisible leading space.

Comment 8

[Uri Bernstein]

Hmmm... I just realized this is probably a duplicate of bug 138245, although now that this one has a patch, you might want to dupe that one to this one.
See also bug 252441.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

right.

dup to bug 138245.

*** This bug has been marked as a duplicate of 138245 ***

Comment 10

[Uri Bernstein]

(In reply to comment #7)
> So should we be selecting the (invisible) trailing space?
> We don't select invisible leading space.
> 

That trailing space used to be selectable (and not "invisible") until the recent fix for bug 132561. Now that it's invisible, I guess it shouldn't be selected by triple-click, but I need to think about this a bit more.

Comment 11

[[e-mail]]

(In reply to comment #10)
>That trailing space used to be selectable (and not "invisible") until the
>recent fix for bug 132561. Now that it's invisible, I guess it shouldn't be
>selected by triple-click, but I need to think about this a bit more.
That's OK, I since decided that it's useful to drop untrimmed URLs.