Closed Bug 350181 Opened 18 years ago Closed 18 years ago

Check whether the requestee is allowed to set a flag

Categories

(Bugzilla :: Attachments & Requests, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

When you ask someone to set a flag, Flag::validate() should make sure that this requestee is in the grant group, if such a group exists for this flag type. Else he won't be able to do anything with this request.
Attached patch patch, v1Splinter Review
Per my discussion with beltzner on IRC, we came to the conclusion that it may be helpful to display the group name in the error message.
Attachment #235403 - Flags: review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/Flag.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm new revision: 1.77; previous revision: 1.76 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.185; previous revision: 1.184 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Keywords: relnote
Added to the release notes on bug 255155.
Keywords: relnote
The correct bug number for those release notes is actually bug 349423.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: