350319 - Strict warning: function getStyleSheet does not always return a value

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Warning: function getStyleSheet does not always return a value
Source File: chrome://calendar/content/calendar-views.js
Line: 235
Source Code:
}

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: fix strict warnings

Fix the warning mentioned in summary. But I could not resist and also fixed

Warning: Expected color but found 'null'.  Error in parsing value for property 'background-color'.  Declaration dropped.
Source File: chrome://calendar/content/preferences/editCategory.xul Line: 0

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 235588 [details] [diff] [review]
fix strict warnings

r1=lilmatt

Comment 3

[Joey Minta]

Comment on attachment 235588 [details] [diff] [review]
fix strict warnings

    function toggleColor()
    {
       if(document.getElementById("useColor").checked)
          document.getElementById("categoryColor").color = oldColor;
       else {
          oldColor = document.getElementById("categoryColor").color;
-         document.getElementById("categoryColor").color=null;
+         document.getElementById("categoryColor").removeAttribute("color");
       }
The strict warning here seems to be unavoidable.    For me, on the 1.8.1 branch, a color will stay chosen if i uncheck the color checkbox with this patch.

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> The strict warning here seems to be unavoidable. For me, on the 
> 1.8.1 branch, a color will stay chosen if i uncheck the color 
> checkbox with this patch

This works fine for me in win32 Sunbird build from MOZILLA_1_8_BRANCH (with this patch). Not testable in Lightning at the moment because there is no UI to select or edit categories.

Comment 5

[Stefan Sitter [:ssitter]]

Attachment: fix strict warning

Now that we have 1.8.1 branch builds I'll try to reproduce the issue mentioned in Comment #3 in the original bug.

Comment 6

[Matthew (lilmatt) Willis]

Comment on attachment 255385 [details] [diff] [review]
fix strict warning

r=lilmatt

Comment 7

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED