350424 - Search is broken

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Regression between 1.9a1_2006082710 and 1.9a1_2006082716.
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-08-27+09%3A00&maxdate=2006-08-27+17%3A00

Comment 1

[Dave Townsend [:mossop]]

Can you give some more concrete info on the problem here?

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Debracket

Woo, bug 350268 is going to provide lots of little bits of cleanup for me, isn't it?

Comment 3

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #1)
> Can you give some more concrete info on the problem here?
>

The searchbox is non-functional; I see only errors. 

Comment 4

[Phil Ringnalda (:philor)]

Ria, you don't need to mark all the bugs that 350268 will expose as though they are regressions that it caused: it throws an error for an error, instead of silently ignoring it the way we did before.

Comment 5

[Brendan Eich [:brendan]]

It's ok with me if people treat 350268 as a regression -- if it's the best way to link bugs to show what caused what, link away.

/be

Comment 6

[Phil Ringnalda (:philor)]

Jesse was just telling me the same thing, so, sorry Ria, I was twice-wrong :(

Comment 7

[Asaf Romano (gone)]

Comment on attachment 235700 [details] [diff] [review]
Debracket

fun, r=mano.

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 235700 [details] [diff] [review]
Debracket

Safe fix to pick up for 1.8.1/fx2 so we don't have to worry if the fix for bug 350268 makes it into that branch at some point.

/be

Comment 9

[Mike Schroepfer]

Comment on attachment 235700 [details] [diff] [review]
Debracket

a=schrep - figuring we want search working in the nightlies :-)

Comment 10

[Mike Schroepfer]

ahh - note to self that 350268 is not going onto branch so this bug isn't so critical there.

Comment 11

[Asaf Romano (gone)]

Checking in browser/components/search/content/search.xml;
/cvsroot/mozilla/browser/components/search/content/search.xml,v  <--  search.xml

new revision: 1.86; previous revision: 1.85
done

Comment 12

[Phil Ringnalda (:philor)]

*** Bug 350443 has been marked as a duplicate of this bug. ***

Comment 13

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/content/search.xml 	1.37.2.56

Comment 14

[Phil Ringnalda (:philor)]

*** Bug 350583 has been marked as a duplicate of this bug. ***