350441 - Phishing Protection does not display warning bubble when local list used

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Reed Loden [:reed]]

Well, it seems phishing protection was broken sometime over the last couple of days. When I go to Google Safe Browsing Test Page now, I do not get any type of bubble when using the "Check using a downloaded list of suspected sites" option. When I choose "Check by asking Google about each site I visit," the warning bubble appears again. When I swap back to the default option, the bubble does not display.

Error: this.listManager_ has no properties
Source File: file:///C:/Program%20Files/Bon%20Echo/components/nsSafebrowsingApplication.js
Line: 2160

Comment 1

[Reed Loden [:reed]]

*** Bug 350459 has been marked as a duplicate of this bug. ***

Comment 2

[Tony Chang (Google)]

Can you try some urls on this list (what's being downloaded):
http://sb.google.com/safebrowsing/update?client=navclient-auto-ffox&version=goog-black-url:1:-1

This is a bug where the test pages are only being checked in remote lookup mode. I'm not sure when it regressed, I think that the phish-o-rama page was recently removed from the blacklist.

Not sure about the exception, I'll look into that today.

Comment 3

[Tony Chang (Google)]

(In reply to comment #2)
> This is a bug where the test pages are only being checked in remote lookup
> mode. I'm not sure when it regressed, I think that the phish-o-rama page was
> recently removed from the blacklist.

Also, there's a fix for this on bug 349102.

Comment 4

[Majken Connor [:Kensie]]

http://labachelor.com/www.paypal.com/cgi-bin/primapagina.htm pulled up the phishing dialog

http://lfpalszliiix.info/ didn't, I guess cuz it redirects to http://www.paypal.com.lfpalszliiix.info/webscr.php?cmd=LogIn ?

http://montevia.el-monte.net/firma/ pulled up the dialog even though the server was not found, pretty cool.

so looks like it's just the test page - http://www.google.com/tools/firefox/safebrowsing/phish-o-rama.html

Although this DID work - http://www.google.com/tools/firefox/toolbar/FT2/intl/en/phish-o-rama.html

Comment 5

[Tony Chang (Google)]

I'm wrong.  This was regressed in bug 348625 patch "use whitelist to suppress remote lookups."  This went in after the b2 freeze.

Comment 6

[Tony Chang (Google)]

Fixed by the patch on bug 349102.