Closed
Bug 350597
Opened 18 years ago
Closed 15 years ago
[RTL] XML preview header should be RTL in RTL locales
Categories
(Core :: XML, defect)
Core
XML
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: zwnj, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
(Keywords: fixed1.9.1, intl, rtl)
Attachments
(2 files)
94.69 KB,
image/png
|
Details | |
1.57 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
XML preview's header should be right-aligned and have rtl direction in rtl locales. I'm going to attach an screenshot.
Reporter | ||
Comment 1•18 years ago
|
||
Reporter | ||
Updated•18 years ago
|
No longer blocks: Persian-Fx2.0
Updated•18 years ago
|
Component: Layout: BiDi Hebrew & Arabic → XML
OS: AIX → All
Summary: [RTL] XML preview header → [RTL] XML preview header should be RTL in RTL locales
Version: 1.8 Branch → Trunk
Updated•18 years ago
|
Assignee: nobody → xml
QA Contact: layout.bidi → ashshbhatt
Assignee | ||
Comment 2•16 years ago
|
||
A related bug: bug 417489
Assignee | ||
Comment 3•16 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
Assignee | ||
Updated•15 years ago
|
Assignee: xml → ehsan.akhgari
QA Contact: ashshbhatt → xml
Target Milestone: Future → ---
Assignee | ||
Comment 4•15 years ago
|
||
Trivial patch.
Attachment #359974 -
Flags: superreview?(jonas)
Attachment #359974 -
Flags: review?(jonas)
Assignee | ||
Updated•15 years ago
|
Status: NEW → ASSIGNED
Attachment #359974 -
Flags: superreview?(jonas)
Attachment #359974 -
Flags: superreview+
Attachment #359974 -
Flags: review?(jonas)
Attachment #359974 -
Flags: review+
Assignee | ||
Comment 5•15 years ago
|
||
Thanks for the super-quick review, Jonas! <http://hg.mozilla.org/mozilla-central/rev/bdde600b135e>
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-litmus?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Updated•15 years ago
|
Attachment #359974 -
Flags: approval1.9.1?
Assignee | ||
Comment 6•15 years ago
|
||
Comment on attachment 359974 [details] [diff] [review] Patch This is a very low-risk patch which would bring a little more RTL goodness to users of RTL locales.
Comment 7•15 years ago
|
||
Comment on attachment 359974 [details] [diff] [review] Patch a191=beltzner
Attachment #359974 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 8•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d5de346b4074
Keywords: fixed1.9.1
Assignee | ||
Updated•11 years ago
|
Flags: in-litmus?
You need to log in
before you can comment on or make changes to this bug.
Description
•