350741 - [Mac] Text in Remember Password Dialog is too close to the top-left corner

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Jean-Yves Perrier [:teoli]]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2

The text "Password Manager has saved login information for the following sites" is too close to the top-left corner. That's unaesthetic.

Reproducible: Always

Steps to Reproduce:
1. BonEcho->Preferences->Security Tab
2. Click Show Passwords
3.

Actual Results:  
The text is close to the top-left corner

Expected Results:  
Space with the top-left corner should be greater.

Tested with the latest branch nightly; maybe related to the new theme.

Comment 1

[Phil Ringnalda (:philor)]

That's actually a toolkit preference widget bug: Winstripe has /toolkit/themes/winstripe/global/preferences.css to set padding on any prefpane, but for some reason Pinstripe only has /(app)/themes/pinstripe/(app)/preferences.css, so while the prefs UI gets padding from there, a toolkit prefwindow doesn't get any.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Appears to make the passwords dialog non-hideous, without regressing anything elsewhere (that I can see).

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Obligatory screenshot

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 271403 [details] [diff] [review]
Fix v.1

Maybe this will remind me to actually attach the patch that removes the duplicate rules from browser/

Comment 5

[Phil Ringnalda (:philor)]

Attachment: Fix v.2

With the duplicates in browser/ removed (I'll fight with mail/ and its lack of a help button to fill up the bottom separately). Near as I can tell, the !important was bogus, or a workaround for something that's now gone; if not, maybe next time someone will have enough sense to add a comment saying what they are doing with it.

Comment 6

[Asaf Romano (gone)]

Comment on attachment 272027 [details] [diff] [review]
Fix v.2

r=mano

Comment 7

[Phil Ringnalda (:philor)]

browser/themes/pinstripe/browser/preferences/preferences.css 1.20
toolkit/themes/pinstripe/global/jar.mn 1.31
toolkit/themes/pinstripe/global/preferences.css 1.1