350753 - mail account manager tree subbranch order broken

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Karsten Düsterloh]

Up to SM 2006-07-12-09 (Windows), subbranches of an account entry in the mail account manager were sorted like this:
 Server Settings
 Copies & Folders
 Composition & Addressing
 Disk Space
 Junk Settings
 Return Receipts
 Security

Since SM 2006-07-13-09 (Windows), the (dis)order is:
 Disk Space
 Copies & Folders
 Composition & Addressing
 Server Settings
 Junk Settings
 Return Receipts
 Security

The IMO most likely check-in causing this in the regression window seems to be for bug 335122:
<http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=regexp&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-07-12+00%3A00%3A00&maxdate=2006-07-13+10%3A00%3A00&cvsroot=%2Fcvsroot>.

Comment 1

[[e-mail]]

Attachment: Proposed patch

It looks like Enn changed all trees to use sort instead of sortResource (but the good news is that we don't have to manually sort the tree any more).

Comment 2

[Neil Deakin]

Comment on attachment 236207 [details] [diff] [review]
Proposed patch

OK, but it should still work with sortResource though, does it not?

Comment 3

[[e-mail]]

(In reply to comment #2)
>but it should still work with sortResource though, does it not?
Err.. no, it does not, otherwise this bug wouldn't have been filed etc?

Comment 4

[Neil Deakin]

I meant, does it work with sortResource without the manual sorting? If not, then there's still an compatibility issue with the sort service.

Comment 5

[[e-mail]]

Attachment: Updated for Enn's comment

OK, so as Enn says, it's only the manual sorting that's confusing it.

Comment 6

[[e-mail]]

Fix checked in.

Comment 7

[Scott MacGregor]

*** Bug 350945 has been marked as a duplicate of this bug. ***