350814 - RTL tabstrip styling is broken

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Asaf Romano (gone)]

Various theme patches have regressed the styling of RTL tabbrowser tabstrip.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

*** Bug 350999 has been marked as a duplicate of this bug. ***

Comment 3

[Behnam Esfahbod [:zwnj]]

Attachment: Current status

Comment 4

[Behnam Esfahbod [:zwnj]]

Attachment: Current status 2

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 236196 [details] [diff] [review]
patch

r+a=me on this theme bug

Comment 6

[(not reading, please use [e-mail] instead)]

asaf, my apologies for busting RTL here, and thank you for fixing it!

For ff2, are we going to be fixing pinstripe for RTL?

Comment 7

[Asaf Romano (gone)]

(In reply to comment #6)

> For ff2, are we going to be fixing pinstripe for RTL?
> 

No.

Comment 8

[Asaf Romano (gone)]

1.8 branch:
mozilla/toolkit/themes/winstripe/global/globalBindings.xml 1.3.24.3
mozilla/toolkit/themes/winstripe/global/jar.mn 1.14.2.9

Comment 9

[(not reading, please use [e-mail] instead)]

asaf, I have made more changes to fix some issues with the RTL tabstrip styling.  

specifically, I have additional rules to fix tab-image-left when in RTL (and the tab is not selected)

see the patch bug #350690 (which contains the fix for that RTL issue.)

Comment 10

[(not reading, please use [e-mail] instead)]

> specifically, I have additional rules to fix tab-image-left when in RTL

asaf:  I've landed that fix, and made sure that when in RTL mode, we do the right things with the rounded corners.

Comment 11

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).