350837 - cx->throwing is not cleared in finally

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Igor Bukanov]

Consider the following example:

function f()
{
        print("F");
}

try {
        throw 1;
} finally {
        f.call(this);
}

Currently it does not print f() since finally is executed with cx->throwing set. So js_Interpret quits immediately when f is called. Note that this is only visible with not-inlined calls. If f.call(this) is replaced by f(), then f is executed. I guess this is a regression from bug 3150312.

Comment 1

[Igor Bukanov]

Attachment: Fix

The fix clears cx->throwing in [gosub].

Comment 2

[Jesse Ruderman]

Is this related to bug 350702?

Comment 3

[Jesse Ruderman]

> I guess this is a regression from bug 3150312.

Looks like a typo for bug 350312, "Accessing wrong stack slot with nested catch/finally".

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 236214 [details] [diff] [review]
Fix

Ay caramba!

/be

Comment 5

[Igor Bukanov]

I committed the patch from comment 1 to the trunk:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.277; previous revision: 3.276
done

Comment 6

[Igor Bukanov]

*** Bug 350702 has been marked as a duplicate of this bug. ***

Comment 7

[Brendan Eich [:brendan]]

This is a regression that must be fixed in 1.8.1, and ought to be fixed as soon as possible in 1.8.0.x.

/be

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 236214 [details] [diff] [review]
Fix

Different patch needed for 1.8.0 branch, coming right up.

/be

Comment 9

[Brendan Eich [:brendan]]

Attachment: 1.8.0 branch version of patch

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 236214 [details] [diff] [review]
Fix

a=beltzner on behalf of 181drivers

Comment 11

[Brendan Eich [:brendan]]

Fixed on the 1.8.0 branch with in-person a=dveditz.

/be

Comment 12

[Igor Bukanov]

I committed the patch from comment 1 to the MOZILLA_1_8_BRANCH:

Checking in jsinterp.c;
/cvsroot/mozilla/js/src/jsinterp.c,v  <--  jsinterp.c
new revision: 3.181.2.51; previous revision: 3.181.2.50
done

Comment 13

[Bob Clary [:bc] (inactive)]

Checking in regress-350837.js;
/cvsroot/mozilla/js/tests/js1_5/Exceptions/regress-350837.js,v  <--  regress-350837.js
initial revision: 1.1

Comment 14

[Bob Clary [:bc] (inactive)]

verified fixed 1.8, 1.9 20060901 windows/mac*/linux

Comment 15

[Bob Clary [:bc] (inactive)]

verified fixed 1.8.0.7 2006090118 windows/mac*/linux