Last Comment Bug 350928 - Trunk and FF 2.0 prefs off with XForms
: Trunk and FF 2.0 prefs off with XForms
Status: RESOLVED FIXED
: fixed1.8.0.12, fixed1.8.1.4
Product: Core Graveyard
Classification: Graveyard
Component: XForms (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: ---
Assigned To: aaronr
: Stephen Pride
:
Mentors:
Depends on:
Blocks: 353738
  Show dependency treegraph
 
Reported: 2006-08-31 16:07 PDT by aaronr
Modified: 2016-07-15 14:46 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch for trunk and 1.8 (7.19 KB, patch)
2007-04-03 16:08 PDT, aaronr
doronr: review+
bugs: review+
Details | Diff | Splinter Review

Description aaronr 2006-08-31 16:07:15 PDT
Trunk and FF 2.0 preferences has the XForms whitelisting preference (on the 'content' page) at the bottom of the page and in its own section.  It should be in the upper section with the java, javascript, etc. preferences.

We also need to make sure that the fix for this won't break 1.5! :-)
Comment 1 aaronr 2007-04-03 16:08:34 PDT
Created attachment 260521 [details] [diff] [review]
patch for trunk and 1.8

I moved the xforms security pref under the security panel in prefs.  I also had to add code to adjust the size of the pref window since it is hardcoded for most platforms but Mac.  So I took the current values and added 2em to them.  Otherwise the last item in the security panel would slide off the bottom a little bit (bottom border of its group box wouldn't be visible).
Comment 2 aaronr 2007-04-03 16:09:29 PDT
Comment on attachment 260521 [details] [diff] [review]
patch for trunk and 1.8

Olli, could you try this patch on Linux to make sure that it looks ok?
Comment 3 aaronr 2007-04-04 10:11:50 PDT
checked into trunk
Comment 4 aaronr 2007-04-23 16:33:12 PDT
checked into 1.8 branch on 2007-04-12
checked into 1.8.0 branch on 2007-04-16

Note You need to log in before you can comment on or make changes to this bug.