351452 - Fields for custom alarm time cut off in dialog New event

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Thorsten]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2
Build Identifier: Lightning 0.1+ (2006030606)

In the dialog New Event the three fields for a custom alarm time are cut off.

See attached screenshot.

Reproducible: Always

Steps to Reproduce:
1. Start TB and create a new Event in Lightning
2.
3.

Comment 1

[Thorsten]

Attachment: Screenshot of the New Event dialog

Comment 2

[Thorsten]

I think this bug should be solved for the 0.3 release.

Comment 3

[Joey Minta]

Duplicate of bug 351323?

Comment 4

[Matthew (lilmatt) Willis]

(In reply to comment #2)
> I think this bug should be solved for the 0.3 release.

To nominate something as blocking the release, please set the flag to "?".
The release drivers will then determine whether it will block (+) or not (-) and set the flag appropriately.

For more information, see http://wiki.mozilla.org/Calendar/For_Everyone/Blocking_Flags



(In reply to comment #3)
> Duplicate of bug 351323?

It could be related, but the axis of the cutoff is different. Perhaps a dupe.

Comment 5

[Matthew (lilmatt) Willis]

> http://wiki.mozilla.org/Calendar/For_Everyone/Blocking_Flags
That URL should be
http://wiki.mozilla.org/Calendar:For_Everyone:Blocking_Flags

Comment 6

[Stefan Sitter [:ssitter]]

Using Branch (Tb 1.5.0.x, Tb 2.0a1) or Trunk (Tb 3.0a1) build? 
What happens when you resize the dialog? Do you have a regression range?
Maybe this is related to Bug 351323.

Comment 7

[Thorsten]

Attachment: Screenshot of resized New Event dialog

Even when I resize the dialog box, the three fields still remain cut off.

I am using Thunderbird 1.5.0.5 and the lightning build 0.1+ (2006090506)

Comment 8

[Stefan Sitter [:ssitter]]

I think this is not a duplicate of Bug 351323. On Windows 2000 I can't see the custom alarm fields at all. But the dropdown menus stated in Bug 351323 are displayed fine.

WORKS with Tbird/2.0a1   (20060905) + Ltn/0.1+ (2006090506-mozilla1.8)

FAILS with Tbird/1.5.0.5 (20060719) + Ltn/0.1+ (2006090506-mozilla1.8)
FAILS with Tbird/1.5.0.7 (20060905) + Ltn/0.1+ (2006090506-mozilla1.8)

Tbird/3.0a1 (20060905) + Ltn/0.1+ (2006090508-trunk) shows Bug 351323

Comment 9

[Stefan Sitter [:ssitter]]

The problem only occurs with Event dialog, with Task dialog everything is OK.

WORKS with Tbird/1.5.0.5 (20060719) + Ltn/0.1+ (2006-08-18-06-mozilla1.8)
FAILS with Tbird/1.5.0.5 (20060719) + Ltn/0.1+ (2006-08-19-14-mozilla1.8)

Bug 287550 was checked in during that time and changed the dialog. 
Maybe this revealed a xul bug regarding hidden/colapsed elements that is present on MOZILLA_1_8_0_BRANCH but fixed on MOZILLA_1_8_BRANCH.

I also need to test if the changes from Bug 350375 can help here.

Comment 10

[Stefan Sitter [:ssitter]]

Same problem on Linux. In addition I have to revert my statement from Comment #9: Task dialog is also affected: Selecting custom alarm shows the custom alarm fields - but the privacy field above is no longer visible.

Looking closer I think this is caused by the "max-height: 10em;" style set on calendar-attendee-list element.

Comment 11

[Matthew (lilmatt) Willis]

Attachment: Screenshot on Mac

Interestingly enough, this bug doesn't appear on Mac.

Comment 12

[Matthew (lilmatt) Willis]

Attachment: Screenshot on Mac - Lightning 2006-09-08 on Tbird 1.5.0.5 (official, under Rosetta)

Comment 13

[Stefan Sitter [:ssitter]]

Attachment: increase the max-height value

I verified that this is caused by the "max-height: 10em;" style set on
calendar-attendee-list element. 

Removing that style rule fixes the problem. But then the attendee list will grow to infinite height with each line added.

I tested adding/removing flex attribute/style rules in various places but none fixed both problems.

So I decided to increase the max-height value. Setting to 12em makes it work fine on Windows 2000 and Ubuntu Linux. This should also work on Windows XP because the fields are less cut off than on Windows 2000 according to the screenshot. On Mac OS X the problem doesn't show at all - probably this was developed on Mac and 10em is the right size for this system.

Note: This doesn't really fix the problem. It just makes it disappear for now. I suggest to use this change for 0.3 unless someone comes up with a better fix.

Comment 14

[Matthew (lilmatt) Willis]

Comment on attachment 237486 [details] [diff] [review]
increase the max-height value

Still works on Mac okay.

Comment 15

[Matthew (lilmatt) Willis]

Comment on attachment 237486 [details] [diff] [review]
increase the max-height value

dmose's queue is a bit full.

Comment 16

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 237486 [details] [diff] [review]
increase the max-height value

This is totally the wrong way to fix this, but it seems that richlistbox is quite buggy. A simple testbox in a small window doesn't show a scrollbar...

So guess we have to live with this workaround for 
now. But please add a big XXX comment.

r=mvl

Comment 17

[Matthew (lilmatt) Willis]

Patch with big ol' comment checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED

Comment 18

[Johannes Buchner]

(In reply to comment #17)
> Patch with big ol' comment checked in on MOZILLA_1_8_BRANCH and trunk.
Works here. Windows XP.