351625 - Decompilation omits parens around object literal

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jesse Ruderman]

js> function() { ({a:b, c:3}); } 
function () {
    {a:b, c:3};
}

js> function () {
    {a:b, c:3};
typein:6: SyntaxError: invalid label...

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

Main fix is to detect the condition where it arises: JSOP_ENDINIT's Decompile code checks for next ops being group;pop{,v} and if so, parenthesizes.

jsopcode.tbl had the wrong precedence on the wrong op.  A formality in this case, but worth getting right.

/be

Comment 2

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 3

[Bob Clary [:bc] (inactive)]

Checking in regress-351625.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-351625.js,v  <--  regress-351625.js
initial revision: 1.1

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 237064 [details] [diff] [review]
fix

a=beltzner on behalf of 181drivers

Comment 5

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.9a1_2006090707 windows/mac*/linux but 1.8 also passed this test with builds of approximately the same time...

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 1.9 20060909 windows/mac*/linux