351716 - Context menu separators disappear when hovered over

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060906 Minefield/3.0a1

Steps to reproduce:
1. Open the File menu.
2. Move your mouse to the button of the menu and back to the top a few times.

Results:
Menu separators disappear.

Expected results:
Menu separators are still instact.

This regressed between 2006-09-06-04 and 2006-09-07-04, so my bets are on bug 348304 / bug 351318.

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-09-06+03&maxdate=2006-09-07+05&cvsroot=%2Fcvsroot

Comment 1

[[e-mail]]

Attachment: Proposed patch

Bah, who are these theme authors who assume nsITheme support?

Comment 2

[Adam Guthrie]

*** Bug 351796 has been marked as a duplicate of this bug. ***

Comment 3

[Hideo Oshima]

I tried the patch(attachment 237200 [details] [diff] [review]).
It looks good.
Please review it.

Comment 4

[[e-mail]]

Attachment: Alternative patch

Comment 5

[Adam Guthrie]

If we can't get this reviewed and landed today, I think we need to backout bug 70798 seeing as how it's basically a smoketest blocker on Linux (ref. bug 351773).

See also http://talkback-public.mozilla.org/reports/firefox/FFTrunk/FFTrunk-topcrashers.html which shows almost 60 crashes in libc.so.6 since this patch landed. (It's crashing in cairo-related code that deals with drawing the menus.)

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 237200 [details] [diff] [review]
Proposed patch

This is the right thing.

Comment 7

[[e-mail]]

Fix checked in.

Comment 8

[Adam Guthrie]

Verified FIXED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060911 Minefield/3.0a1.