351736 - address book card preview pane problem in high contrast mode

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

address book card preview pane problem in high contrast mode

I've been playing around with high contrast mode on windows xp (try it:
left-shift left-alt printscreen) and I noticed some problems with the address book card  preview pane.

I'll attach a screen shot.

aaronl, is this sec508 keyword worthy?

mark, if you are still hacking on the address book, I think the is probably a lot of relatively low hanging fruit in the crusty xul (mostly mine!) that is the addressbook card preview pane.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot, should be white text on black (need to use -moz-dialog as the color?)

Comment 3

[Wayne Mery (:wsmwk)]

Seth, does this set OS high contrast mode?  search results for all products: http://tinyurl.com/2kjgad   Also, see the FF front in bug 343205.  

[I also played with high contrast several months back and also encountered issues in an ill-fated attempt for better readability. I also had trouble backing it completely out - I forget whether the trouble was at the OS level or in one of the mozilla products.]

Comment 4

[(not reading, please use [e-mail] instead)]

> Seth, does this set OS high contrast mode?

sorry wayne, I don't understand your question.

to enable high contrast mode on windows, do this: 

left shift + left alt + printscreen

Comment 6

[Mark Banner (:standard8)]

Per bug 382417 Hardware/OS to all.

Comment 7

[eldeh]

Possible solution:

The white background color is hard-coded in the file addressbook-css in the classic.jar archive:

--- section start ---

#CardViewBox {
  -moz-user-focus: ignore;
  overflow: auto;
  min-width: 150px;
  background-color: #FFFFFF;   // <--- HERE IS THE PROBLEM
}

--- section end ---

One can change it to something else, e.g.:

  background-color: -moz-Dialog;

Comment 8

[eldeh]

Addition:

This does not work with some other themes than the default theme. Also, userChrome.ccs cannot do the change instead.

Comment 9

[David Ascher (:davida)]

Does this still happen for Shredder nightly builds? If so, we should change the version on the bug.

Comment 10

[hansen]

The #FFFFFF is still in the nightly win32 and linux builds:
http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/addrbook/addressbook.css#320
http://mxr.mozilla.org/comm-central/source/mail/themes/gnomestripe/mail/addrbook/addressbook.css#320

Comment 11

[Mark Banner (:standard8)]

Taking, I think the best thing to do here is to use the same values as tree.css.

Comment 12

[Mark Banner (:standard8)]

Attachment: Possible fix

I must admit I've not tested this fix. However, this makes the #CardViewBox style the same as the #dirTree and #abResultsTree styles wrt color and background color on Windows and Linux. I've left mac alone, as even toolkit's tree.css seems to hard-code white there.

If anyone can test it would be useful to know if it fixes the problem.

Comment 13

[eldeh]

Yes, seems to work for my dark color scheme.

But two colors are strange and seem also to be hardcoded in addressbook.css:


#CardTitle {
  font-size: 150%;
  font-weight: bold;
  border-bottom: 2px solid black;  // <--- Font color would be better here.
  min-width: 120px;
  margin: 0px;
}

.CardViewLink {
  color: blue;  // <--- A current link color would perhaps be better.
  text-decoration: underline;
  cursor: pointer;
}

Comment 14

[eldeh]

I got good results using:


#CardViewBox {
  -moz-user-focus: ignore;
  overflow: auto;
  min-width: 150px;
  background-color: -moz-dialog;   // <-- instead of white or -moz-field - -moz-dialog has here more a kind of "address card effect"
}

#CardTitle {
  font-size: 150%;
  font-weight: bold;
  border-bottom: 2px solid -moz-dialogtext;   // <- instead of black
  min-width: 120px;
  margin: 0px;
}

.CardViewLink {
  color: -moz-hyperlinktext;   // <- instead of blue
  text-decoration: underline;
  cursor: pointer;
}

Comment 15

[Mark Banner (:standard8)]

(In reply to comment #14)
> I got good results using:
...
>   background-color: -moz-dialog;   // <-- instead of white or -moz-field -
> -moz-dialog has here more a kind of "address card effect"
etc.

I just tried this on Windows Vista, it looks reasonable. However on all other platforms, its too much, and IMO doesn't reflect the main mail window. Given that we're considering at some stage in the future putting the address book in a tab (bug 457270) then I don't think we should worry too much about it at this stage, and just make it better for high contrast users.

Comment 16

[Mark Banner (:standard8)]

Attachment: The fix

Improved fix with a couple of extra changes as suggested by eldeh.

Comment 17

[Phil Ringnalda (:philor)]

Comment on attachment 365422 [details] [diff] [review]
The fix

r=me if you switch the -moz-hyperlinktext to -moz-nativehyperlinktext (-moz-hyperlinktext isn't a system color, for this it's just the value of browser.anchor_color, for which we don't have UI, so it's very nearly the same as hardcoding #0000EE), and for all three themes move the text-decoration: underline out of the CardViewLink class where it's not going to get inherited down and into the html|a selector, where it will actually work.

(Gah, I hope there's at least a bug filed on getting rid of that <html:p><html:a> stuff.)

Comment 18

[Mark Banner (:standard8)]

Attachment: The fix v2

Updated patch - I think this is how Phil wants it, though I'm not too keen on the underlines on the links now that this patch fixes them, hence requesting ui-review so that Bryan can hopefully take a quick look.

Comment 19

[Phil Ringnalda (:philor)]

Comment on attachment 375176 [details] [diff] [review]
The fix v2

I wish "now that I've made this actually do what it was trying to do, I don't like it and I'm glad it was broken before" was a less familiar thing to say :)

Comment 20

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 375176 [details] [diff] [review]
The fix v2

looks good

Comment 21

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/54f3c53dbc43