352003 - test for when to build libreg is broken

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Andrew Schultz]

In SeaMonkey, if I disable xpinstall, I get build failures because libreg isn't built.  The test for MOZ_NO_XPCOM_OBSOLETE seems backwards and libreg is also needed if mail is built (the NS4 mail importer seems to use it).

Comment 1

[Andrew Schultz]

Attachment: patch

checking MOZ_MAIL_NEWS in toolkit seems out of place.  I guess the check isn't technically required since both SeaMonkey and TBird still build the obsolete xpcom bits.

Comment 2

[Benjamin Smedberg]

Comment on attachment 237577 [details] [diff] [review]
patch

tier_2_dirs won't do anything. Perhaps you didn't test this after mergning it, or something?

Why are you disabling xpinstall anyway? I don't know of any supported build configuration with mailnews on and xpinstall off.

Comment 3

[Andrew Schultz]

> tier_2_dirs won't do anything. Perhaps you didn't test this after mergning it,
> or something?

indeed

> Why are you disabling xpinstall anyway? I don't know of any supported build
> configuration with mailnews on and xpinstall off.

I have a tree whose sole purpose is to rebuild quickly to identify regressions (narrowing regression windows).  It has everything disabled that can be.

But anyway, I'm not real attached to the part that checks for mail.  So long as the obsolete xpcom part is right.

Comment 4

[Andrew Schultz]

Attachment: patch to use gecko_dirs

Comment 5

[:aceman]

Does this have any meaning after bug 679352?

Comment 6

[Phil Ringnalda (:philor)]

Nope, but then it already didn't have any since some unknown time well before that.