679352 - Remove libreg

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Marco Castelluccio [:marco]]

Remove libreg as its last use was in the Seamonkey Profile Migrator, that is being removed too (see bug 679016).

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Part 1: Clean nsProfileMigrator

Cleaned nsProfileMigrator to remove the last (useless) use of libreg.

Comment 2

[Marco Castelluccio [:marco]]

Gavin, if you are too busy for the review, could you assign it to someone else?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 556006 [details] [diff] [review]
Part 1: Clean nsProfileMigrator

This looks OK to me, but I don't really know the history of this stuff offhand (or when we stopped using it), so perhaps bsmedberg should sign off.

Comment 4

[Benjamin Smedberg]

Comment on attachment 556006 [details] [diff] [review]
Part 1: Clean nsProfileMigrator

This code exists to import the profile list from Firefox <0.9.2 to Firefox >=0.9.3. I think it can go now.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Part 2: Remove libreg

The Part 1 patch could be checked-in in the meantime.
This patch instead removes libreg and libreg references in the makefiles.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 560489 [details] [diff] [review]
Part 2: Remove libreg

Kill it with fire!

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81a7f5489ebc
https://hg.mozilla.org/integration/mozilla-inbound/rev/971ed890c27d

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/81a7f5489ebc
https://hg.mozilla.org/mozilla-central/rev/971ed890c27d

Comment 9

[Ed Morley [:emorley]]

Callek asked me to back this out of m-c, since it's burning comm-central, but that the c-c change will be landing shortly after the aurora uplift & then this can re-land straight after :-) 

https://hg.mozilla.org/mozilla-central/rev/183d0e60d82c
https://hg.mozilla.org/mozilla-central/rev/c722928d8b69

(Bug #s and dependencies to follow)

Comment 10

[Justin Wood (:Callek)]

(In reply to Ed Morley [:edmorley] from comment #9)
> Callek asked me to back this out of m-c, since it's burning comm-central,
> but that the c-c change will be landing shortly after the aurora uplift &
> then this can re-land straight after :-) 
> 
> https://hg.mozilla.org/mozilla-central/rev/183d0e60d82c
> https://hg.mozilla.org/mozilla-central/rev/c722928d8b69
> 
> (Bug #s and dependencies to follow)

To be clear, I'm not exactly blocking on comm-central here, just wanting either the comm-central fix in hand, or the aurora uplift to have happened. So comm doesn't have to deal with this fallout during and after merge-day. (I'll file bug within 24 hours, likely less)

Comment 11

[(not currently active) Ted Mielczarek]

Can we re-land this, or are we waiting on the c-c bugs to get fixed?

Comment 12

[Marco Castelluccio [:marco]]

Attachment: Part 1: Clean nsProfileMigrator v2

Patch unbitrotted.

Comment 13

[Marco Castelluccio [:marco]]

Attachment: Part 2: Remove libreg v2

Patch unbitrotted.
I've also done a small change in "/browser/components/build/Makefile.in". Could you check it?

Comment 14

[Marco Castelluccio [:marco]]

After the change in the latest patch has been checked, the patches could be checked-in.

Comment 15

[Ed Morley [:emorley]]

Minor makefile change looks fine to me, it's a no-op and this has had r+ already, so should be fine to push as long as try comes up green. (Prior discussions with Callek on IRC + comment 10 + the urgency of bug 709193, means that this doesn't need to be blocked by the c-c changes).

https://tbpl.mozilla.org/?tree=Try&rev=e1b435a80f0d

Really hoping this + the other things we're trying in bug 709193 help the PGO situation.

Comment 16

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d0984bdd95
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5578fdc50ef

\o/

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b9d0984bdd95
https://hg.mozilla.org/mozilla-central/rev/f5578fdc50ef