Remove libreg as its last use was in the Seamonkey Profile Migrator, that is being removed too (see bug 679016).
Created attachment 556006 [details] [diff] [review] Part 1: Clean nsProfileMigrator Cleaned nsProfileMigrator to remove the last (useless) use of libreg.
Gavin, if you are too busy for the review, could you assign it to someone else?
Comment on attachment 556006 [details] [diff] [review] Part 1: Clean nsProfileMigrator This looks OK to me, but I don't really know the history of this stuff offhand (or when we stopped using it), so perhaps bsmedberg should sign off.
Comment on attachment 556006 [details] [diff] [review] Part 1: Clean nsProfileMigrator This code exists to import the profile list from Firefox <0.9.2 to Firefox >=0.9.3. I think it can go now.
Created attachment 560489 [details] [diff] [review] Part 2: Remove libreg The Part 1 patch could be checked-in in the meantime. This patch instead removes libreg and libreg references in the makefiles.
Comment on attachment 560489 [details] [diff] [review] Part 2: Remove libreg Kill it with fire!
Callek asked me to back this out of m-c, since it's burning comm-central, but that the c-c change will be landing shortly after the aurora uplift & then this can re-land straight after :-) https://hg.mozilla.org/mozilla-central/rev/183d0e60d82c https://hg.mozilla.org/mozilla-central/rev/c722928d8b69 (Bug #s and dependencies to follow)
(In reply to Ed Morley [:edmorley] from comment #9) > Callek asked me to back this out of m-c, since it's burning comm-central, > but that the c-c change will be landing shortly after the aurora uplift & > then this can re-land straight after :-) > > https://hg.mozilla.org/mozilla-central/rev/183d0e60d82c > https://hg.mozilla.org/mozilla-central/rev/c722928d8b69 > > (Bug #s and dependencies to follow) To be clear, I'm not exactly blocking on comm-central here, just wanting either the comm-central fix in hand, or the aurora uplift to have happened. So comm doesn't have to deal with this fallout during and after merge-day. (I'll file bug within 24 hours, likely less)
Can we re-land this, or are we waiting on the c-c bugs to get fixed?
Created attachment 580644 [details] [diff] [review] Part 1: Clean nsProfileMigrator v2 Patch unbitrotted.
Created attachment 580646 [details] [diff] [review] Part 2: Remove libreg v2 Patch unbitrotted. I've also done a small change in "/browser/components/build/Makefile.in". Could you check it?
After the change in the latest patch has been checked, the patches could be checked-in.
Minor makefile change looks fine to me, it's a no-op and this has had r+ already, so should be fine to push as long as try comes up green. (Prior discussions with Callek on IRC + comment 10 + the urgency of bug 709193, means that this doesn't need to be blocked by the c-c changes). https://tbpl.mozilla.org/?tree=Try&rev=e1b435a80f0d Really hoping this + the other things we're trying in bug 709193 help the PGO situation.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9d0984bdd95 https://hg.mozilla.org/integration/mozilla-inbound/rev/f5578fdc50ef \o/