Closed Bug 679352 Opened 13 years ago Closed 12 years ago

Remove libreg

Categories

(Core :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: marco, Assigned: marco)

References

Details

(Whiteboard: [iOS])

Attachments

(2 files, 2 obsolete files)

Remove libreg as its last use was in the Seamonkey Profile Migrator, that is being removed too (see bug 679016).
Assignee: nobody → mar.castelluccio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Depends on: 674014
Blocks: deadcode
Depends on: 679016
Whiteboard: [iOS]
Attached patch Part 1: Clean nsProfileMigrator (obsolete) — Splinter Review
Cleaned nsProfileMigrator to remove the last (useless) use of libreg.
Attachment #556006 - Flags: review?(gavin.sharp)
Gavin, if you are too busy for the review, could you assign it to someone else?
Comment on attachment 556006 [details] [diff] [review]
Part 1: Clean nsProfileMigrator

This looks OK to me, but I don't really know the history of this stuff offhand (or when we stopped using it), so perhaps bsmedberg should sign off.
Attachment #556006 - Flags: review?(gavin.sharp) → review?(benjamin)
Comment on attachment 556006 [details] [diff] [review]
Part 1: Clean nsProfileMigrator

This code exists to import the profile list from Firefox <0.9.2 to Firefox >=0.9.3. I think it can go now.
Attachment #556006 - Flags: review?(benjamin) → review+
Attached patch Part 2: Remove libreg (obsolete) — Splinter Review
The Part 1 patch could be checked-in in the meantime.
This patch instead removes libreg and libreg references in the makefiles.
Attachment #560489 - Flags: review?(gavin.sharp)
Attachment #560489 - Flags: review?(gavin.sharp) → review?(khuey)
Comment on attachment 560489 [details] [diff] [review]
Part 2: Remove libreg

Kill it with fire!
Attachment #560489 - Flags: review?(khuey) → review+
Keywords: checkin-needed
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/81a7f5489ebc
https://hg.mozilla.org/mozilla-central/rev/971ed890c27d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
Callek asked me to back this out of m-c, since it's burning comm-central, but that the c-c change will be landing shortly after the aurora uplift & then this can re-land straight after :-) 

https://hg.mozilla.org/mozilla-central/rev/183d0e60d82c
https://hg.mozilla.org/mozilla-central/rev/c722928d8b69

(Bug #s and dependencies to follow)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [iOS] → [iOS] [waiting for c-c changes]
Target Milestone: mozilla9 → ---
(In reply to Ed Morley [:edmorley] from comment #9)
> Callek asked me to back this out of m-c, since it's burning comm-central,
> but that the c-c change will be landing shortly after the aurora uplift &
> then this can re-land straight after :-) 
> 
> https://hg.mozilla.org/mozilla-central/rev/183d0e60d82c
> https://hg.mozilla.org/mozilla-central/rev/c722928d8b69
> 
> (Bug #s and dependencies to follow)

To be clear, I'm not exactly blocking on comm-central here, just wanting either the comm-central fix in hand, or the aurora uplift to have happened. So comm doesn't have to deal with this fallout during and after merge-day. (I'll file bug within 24 hours, likely less)
Depends on: 689120
Depends on: 689437
Can we re-land this, or are we waiting on the c-c bugs to get fixed?
Patch unbitrotted.
Attachment #556006 - Attachment is obsolete: true
Blocks: 709193
Patch unbitrotted.
I've also done a small change in "/browser/components/build/Makefile.in". Could you check it?
Attachment #560489 - Attachment is obsolete: true
After the change in the latest patch has been checked, the patches could be checked-in.
Minor makefile change looks fine to me, it's a no-op and this has had r+ already, so should be fine to push as long as try comes up green. (Prior discussions with Callek on IRC + comment 10 + the urgency of bug 709193, means that this doesn't need to be blocked by the c-c changes).

https://tbpl.mozilla.org/?tree=Try&rev=e1b435a80f0d

Really hoping this + the other things we're trying in bug 709193 help the PGO situation.
Whiteboard: [iOS] [waiting for c-c changes] → [iOS]
https://hg.mozilla.org/mozilla-central/rev/b9d0984bdd95
https://hg.mozilla.org/mozilla-central/rev/f5578fdc50ef
Status: REOPENED → RESOLVED
Closed: 13 years ago12 years ago
Resolution: --- → FIXED
Blocks: 303657
Blocks: 352003
Blocks: 750661
No longer blocks: 750661
You need to log in before you can comment on or make changes to this bug.