352010 - Incorrect decompilation for object literal with getter (js1_5/Regress/regress-313803.js)

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

js> function() { return ({get z(){ return /x/g } }) }       
function () {
    return {get z() {return /x/g;};
}

Comment 1

[Brendan Eich [:brendan]]

Jesse, mrbkap: this is familiar.  Either it's a dup, or something re-created the bug I'm remembering.  Either of you know which?

/be

Comment 2

[Bob Clary [:bc] (inactive)]

this looks like bug 313803 which just regressed
js1_5/Regress/regress-313803.js

BUGNUMBER: 313803
STATUS: uneval() on func with embedded objects with getter or setter
FAILED!: uneval() on func with embedded objects with getter or setter
FAILED!: 
Expected value 
'(function ff() {obj = {get foo () {return "foo";}};return 1;})', 
Actual value 
'(function ff() {obj = {get foo() {return "foo";};return 1;})'
FAILED!: 

Comment 3

[Brendan Eich [:brendan]]

Bob, thanks -- any idea which patch regressed this?

/be

Comment 4

[Brendan Eich [:brendan]]

Attachment: fix

The patches for bug 306738 and bug 313803 assumed parenthesization of the function expression, but we don't do that any longer.  I've added assertions to help catch regressions like this sooner.

/be

Comment 5

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 6

[Mike Schroepfer]

Comment on attachment 237840 [details] [diff] [review]
fix

a=schrep

Comment 7

[Bob Clary [:bc] (inactive)]

*** Bug 352274 has been marked as a duplicate of this bug. ***

Comment 8

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 20060914 windows/linux 1.9 20060914 windows/mac*/linux