We should upgrade NSS used by PSM to NSS release 3.11.3
Created attachment 238553 [details] [diff] [review] Trunk patch v1
Attachment #238553 - Flags: review?(wtchang)
Comment on attachment 238553 [details] [diff] [review] Trunk patch v1 r=wtc.
Attachment #238553 - Flags: review?(wtchang) → review+
Created attachment 238557 [details] [diff] [review] 1.8 branch patch v1
Attachment #238557 - Flags: review?(wtchang)
Comment on attachment 238557 [details] [diff] [review] 1.8 branch patch v1 r=wtc.
Attachment #238557 - Flags: review?(wtchang) → review+
fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Is there something in here that's important for Firefox 2? If so, it needs to get in by approximately yesterday at the latest...
Sorry we missed the deadline. I didn't know about the deadline yesterday. Most of the changes in this patch are for FIPS validation. One change is Solaris only. One change modifies conditionally compiled code. We want Firefox 2.0 to use an official NSS release.
Comment on attachment 238557 [details] [diff] [review] 1.8 branch patch v1 Requesting MOZILLA_1_8_BRANCH checkin approval. The reason for the request is for Firefox 2 to use the NSS 3.11.3 final release. Right now Firefox 2 is using NSS 3.11.2 Beta. It doesn't look good to have a component that is marked as Beta. The changes in this patch are: 1. mozilla/security/nss/manifest.mn Makefile change that doesn't affect Firefox. 2. mozilla/security/nss/lib/freebl/config.mk mozilla/security/nss/lib/freebl/unix_rand.c A Solaris only change. Doesn't affect any other platforms. 3. mozilla/security/nss/lib/nss/nss.h Remove "Beta" from NSS version string. Indicate the level of elliptic curve cryptography support in the NSS version string. 4. mozilla/security/nss/lib/softoken/fipstest.c Fixed a memory leak in the FIPS mode power-up self-test. 5. mozilla/security/nss/lib/softoken/fipstokn.c Fixed a null pointer deference in the FIPS audit logging code. 6. mozilla/security/nss/lib/softoken/pkcs11c.c A change required for the FIPS test program. Does not affect Firefox. 7. mozilla/security/nss/lib/ssl/ssl3con.c Add more SSL tracing. Most of the change is inside an #ifdef that's not compiled by Firefox. All changes have received at least two code reviews. NSS 3.11.3 went through NSS's QA certification process. We tested NSS 3.11.3 with Firefox 2 and two server products, in addition to running our own test suite. The risk of this patch is low.
Attachment #238557 - Flags: approval1.8.1?
Comment on attachment 238557 [details] [diff] [review] 1.8 branch patch v1 Approved for RC2.
Attachment #238557 - Flags: approval1.8.1? → approval1.8.1+
Thanks. I checked in "1.8 branch patch v1" on the MOZILLA_1_8_BRANCH.
v. via lxr
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.