353182 - Teach nsIncrementalDownload to throttle download rate

Status: RESOLVED WONTFIX

(Core :: Networking, defect)

Description

[Darin Fisher]

Teach nsIncrementalDownload to throttle download rate

i.e., deal with bug 352853 in a smarter way.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Here's a fairly simple patch for this bug.  I chose to make the interval between ODA events proportional to mInterval so that 1) I would not need a new configuration parameter, and 2) so that the period between ODA events would not be larger than mInterval.  The value is capped to 3 seconds to help avoid the problem of servers dropping the connection.

Comment 2

[Radek 'sysKin' Czyz]

This patch measures download speed - how about, if this is high enough (definitely  not dial up), you just stop throttling completely?
This way, people with real broadband (>1mbps?) will not hold the server busy any longer than needed.

Comment 3

[Darin Fisher]

I agree.  That would be better.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #2)
> This patch measures download speed 

It actually doesn't...

Comment 5

[Darin Fisher]

-> reassign to default owner

Comment 7

[Patrick McManus [:mcmanus]]

I'm going to wontfix this, but I would take a patch letting a normal http channel do throttling - then that could replace the incremental downloader