regression: Tabs are closed when right-clicking the close button

VERIFIED FIXED in Firefox 2

Status

()

VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: zeniko, Assigned: zeniko)

Tracking

({regression, verified1.8.1})

2.0 Branch
Firefox 2
regression, verified1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [rc ridealong])

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
... which is not what all other close buttons (Find bar, sidebar, etc.) do and which could lead to unexpected dataloss.
(Assignee)

Comment 1

12 years ago
Created attachment 239148 [details] [diff] [review]
fix: only react on left-clicks

Nominating for 1.8.1 in case there's a second RC.
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #239148 - Flags: review?
Attachment #239148 - Flags: approval1.8.1?
(Assignee)

Updated

12 years ago
Attachment #239148 - Flags: review? → review?(mano)
(Assignee)

Updated

12 years ago
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
Comment on attachment 239148 [details] [diff] [review]
fix: only react on left-clicks

oy! r=mano. Many thanks Simon.
Attachment #239148 - Flags: review?(mano) → review+
Drivers: this is a regression form bug 352021, the attached patch should be very safe to take.
Summary: Tabs are closed when right-clicking the close button → regression: Tabs are closed when right-clicking the close button

Comment 4

12 years ago
Based on the description, it sounds like this patch disables the ability to middle click on the close button to close the tab.  Will middle-click still function with this patch?
trunk: mozilla/toolkit/content/widgets/tabbrowser.xml 1.201
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: rcridealong
Whiteboard: rcridealong → [rc ridealong]

Comment 7

12 years ago
I am also getting this bug and I am using a trunk build.

Comment 8

12 years ago
getting it on trunk to.

Comment 9

12 years ago
Sorry this is fixed for me in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060921 Minefield/3.0a1

Sorry again.

Comment 10

12 years ago
Comment on attachment 239148 [details] [diff] [review]
fix: only react on left-clicks

Approved for RC2 (regression fix).
Attachment #239148 - Flags: approval1.8.1? → approval1.8.1+
1.8:
mozilla/toolkit/content/widgets/tabbrowser.xml 1.103.2.95
Keywords: fixed1.8.1
verified with 2.0rc2 candidate builds on Mac and Windows
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.