Closed
Bug 353341
Opened 18 years ago
Closed 18 years ago
Update shipped-locales file for FF2 milestones
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2
People
(Reporter: timr, Assigned: preed)
References
Details
Attachments
(2 files, 3 obsolete files)
482 bytes,
patch
|
timr
:
review+
|
Details | Diff | Splinter Review |
388 bytes,
patch
|
timr
:
review+
|
Details | Diff | Splinter Review |
We are handling the handoff from the L10n team (axel) and QA to the Build team via a copy of the shipped-locales file. We will attach a copy of the file to this bug and request approvals. Whoever updated the attachment (between Axel, QA, and Build) will request reviewer approval by the other two. Typically Axel will be the super reviewer.
Bug 350001 was the original bug for this prupose for Beta2. This is meant to be the the generic bug for the remaining milestones of FF2.
Reporter | ||
Comment 1•18 years ago
|
||
Attachment #239187 -
Flags: superreview?(l10n)
Attachment #239187 -
Flags: review?
Comment 2•18 years ago
|
||
Comment on attachment 239187 [details]
shipped-locales file for RC1
We talked about some kind of mini-branching with rhelmer, this is the version for RC1, we'll most likely need to cut that list for fx2.
Attachment #239187 -
Flags: superreview?(l10n) → superreview+
Reporter | ||
Comment 3•18 years ago
|
||
Just to let everyone know, I added the following 10 locales to the list from Beta2 based on a conversation with Axel:
be - Belarusian
en-ZA - South African English
ga-IN - Gaelic
nr - South Ndebele
pt-BR - Portuguese-Brazillian
ss - Swati
st - South Sotho
tn - Tswana
ts - Tsonga
ve - Venda
This makes 51 locales! As Axel said, these may not all ship for FF2. This is meant to be on the generous side as it is easier to pull a few at the end rather than build and test more at the end.
Reporter | ||
Updated•18 years ago
|
Attachment #239187 -
Flags: review? → review+
Assignee | ||
Comment 4•18 years ago
|
||
This is probably something I need to care about for tonight's l10n spins. :-)
Assignee: nobody → preed
Reporter | ||
Comment 5•18 years ago
|
||
This is the same as the original shipped-locales for RC1 with the following two exceptions:
1) Removed ga-IN which Axel declared not ready
2) Added in the mac platform for pa-IN (removed the stipulation for only Win and Linux). This is due to testing by a team in India who found the pa-IN MacOS build acceptable.
Attachment #240062 -
Flags: superreview?
Attachment #240062 -
Flags: review?
Reporter | ||
Updated•18 years ago
|
Attachment #240062 -
Flags: review? → review?(l10n)
Reporter | ||
Updated•18 years ago
|
Attachment #240062 -
Flags: superreview? → superreview?(l10n)
Assignee | ||
Comment 6•18 years ago
|
||
This is the same file as timr's version in comment 5, except win32 gu-IN builds were broken for a time, and missed the train for RC1:
http://groups.google.com/group/mozilla.dev.planning/tree/browse_frm/thread/8d308bfa7f125d90/b0daf2d900f1dae7?rnum=11&_done=%2Fgroup%2Fmozilla.dev.planning%2Fbrowse_frm%2Fthread%2F8d308bfa7f125d90%2Fb0daf2d900f1dae7%3Ftvc%3D1%26#doc_f38e534d237efc6e
Attachment #240062 -
Attachment is obsolete: true
Attachment #240079 -
Flags: superreview?(l10n)
Attachment #240079 -
Flags: review?(timr)
Attachment #240062 -
Flags: superreview?(l10n)
Attachment #240062 -
Flags: review?(l10n)
Reporter | ||
Comment 7•18 years ago
|
||
Comment on attachment 240079 [details] [diff] [review]
Final shipped locales for RC1, Take II
This is fine for RC1 given we have an RC2 planned
Attachment #240079 -
Flags: review?(timr) → review+
Comment 8•18 years ago
|
||
We want to take the patches for bug 354826, bug 354294 for RC2, we should use revision 1.1.4.9 of shipped-locales.
Depends on: 354294
Comment 9•18 years ago
|
||
Attaching the actual shipped-locales rev 1.1.4.9 for reference and sign-off by timr.
Attachment #239187 -
Attachment is obsolete: true
Attachment #240878 -
Flags: review?(timr)
Reporter | ||
Comment 10•18 years ago
|
||
Axel- I thought you said something about pa-IN being broken. This was in the L10n-drivers meeting Fri I think. Maybe I am mixing this up with something else. Please confirm that the only change should be taking out the african locales and adding back in gu-IN Win32.
Comment 11•18 years ago
|
||
(In reply to comment #10)
> Axel- I thought you said something about pa-IN being broken. This was in the
> L10n-drivers meeting Fri I think. Maybe I am mixing this up with something
> else. Please confirm that the only change should be taking out the african
> locales and adding back in gu-IN Win32.
pa-IN was fixed in bug 354826. :)
Version: 1.5.0.x Branch → 2.0 Branch
Comment 12•18 years ago
|
||
Yep, what reed said.
We morphed bug 354826 from "remove pa-IN" to "fix it", as I got a check-in window after the code freeze, and the fixes were in fact simple enough.
Comment 13•18 years ago
|
||
Let's get this addition reviewed by both Tim and schrep, I have mixed feeling of adding back a locale for RC2.
http://litmus.mozilla.org/search_results.cgi?locale=ga-IE has the test results, so independent of the missing RC1, I do think we have traction on ga-IE.
Attachment #240901 -
Flags: superreview?(mtschrep)
Attachment #240901 -
Flags: review?(timr)
Reporter | ||
Comment 14•18 years ago
|
||
Comment on attachment 240901 [details] [diff] [review]
add ga-IE back to shipped-locales
ga-IE is a tier three. We have previously tested Win and Linux. We are really just adding back in Mac from a testing perspective. It shouldn't be a problem.
Attachment #240901 -
Flags: review?(timr) → review+
Comment 15•18 years ago
|
||
Comment on attachment 240079 [details] [diff] [review]
Final shipped locales for RC1, Take II
cleaning up some review flags in this bug
Attachment #240079 -
Flags: superreview?(l10n)
Updated•18 years ago
|
Attachment #240878 -
Attachment is obsolete: true
Attachment #240878 -
Flags: review?(timr)
Comment 16•18 years ago
|
||
Comment on attachment 240901 [details] [diff] [review]
add ga-IE back to shipped-locales
This landed for RC2.
Attachment #240901 -
Flags: superreview?(mtschrep)
Assignee | ||
Comment 17•18 years ago
|
||
2.0 is shipped!
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•6 years ago
|
Target Milestone: Firefox 2 → mozilla2
You need to log in
before you can comment on or make changes to this bug.
Description
•