354826 - fix pa-IN problems in defines.inc and tabs.dtd

Status: RESOLVED FIXED

(Mozilla Localizations :: pa-IN / Punjabi, defect)

Description

[Axel Hecht [:Pike]]

There are XML parsing errors in the pa-IN build, which no tool caught without running.
In addition, I have been unable to create a working langpack, and haven't been able to understand that error.

The xml parsing error is real, though. It doesn't pull brand.dtd in tabs.dtd, but uses &bandShortName;, which makes the prefwindow look bad in the tabs pane.

Comment 1

[Axel Hecht [:Pike]]

Getting this on the radar.

I have a fix in hand, but I still need to actually make the patch. The XML parsing error is fixed, though, and I'm confident I found the bug in the langpack.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Plussing to keep it on the radar. In addition to the problems that Axel mentions, there's also problems with the pa-IN help files. Depending on the timing of getting a patch together, we can either take a fix or pull the build from shipped-locales.

Comment 3

[Axel Hecht [:Pike]]

Attachment: fix defines.inc and tabs.dtd

This patch fixes defines.inc to actually be a proper defines.inc, and fixes tabs.dtd to include brand.dtd and no line numbers instead.

Requesting approval1.8.1 to get this landed.

Comment 4

[Axel Hecht [:Pike]]

Landed the two bustage fixes. Help is not in the best condition, but it offers some basic functionality.

Hrm. I could have CCed Amanpreet earlier, too.

Comment 5

[Cédric Corazza]

Attachment: Fix for help files

As far as I could see, help is in English and not uptodate. Simply copy-pasting en-US into pa-IN and making a diff. If this could help.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 240657 [details] [diff] [review]
Fix for help files

Not going to attack help for 2.0

Comment 7

[Axel Hecht [:Pike]]

This is FIXED, too.

Comment 8

[Axel Hecht [:Pike]]

I'm sooooo stupid, and I'm really sorry.

The embarrassment that is attachment 242846 [details] over in bug 353341 is mine, and the patch even shows.

Not FIXED, not fixed1.8.1, and stop-ship, IMHO.

Requesting blocking1.8.1.1 to get that fixed in the next minor release.

Note to self: slam your head against the wall.

Comment 9

[Mike Connor [:mconnor]]

moving flags appropriately

Comment 10

[Marek Stępień [:marcoos, inactive]]

Attachment: Unbreak tabs.dtd

This patch replaces Pike's "=========" strings with the real Punjabi strings he deleted, but still keeps the tabs.dtd well-formed. :)

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 244986 [details] [diff] [review]
Unbreak tabs.dtd

please nominate for approval only after it's been reviewed

Comment 12

[A S Alam]

yes this patch contains Punjabi translation by removing =====.
it is ok to include.

thanks

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 244986 [details] [diff] [review]
Unbreak tabs.dtd

[pa-IN] approval to fix tabs.dtd for firefox 2.0.0.1 granted.

Amanpreet, please check in the fixed tabs.dtd on the MOZILLA_1_8_BRANCH with a check-in comment referencing this bug and my approval. Add the fixed1.8.1.1 keyword to this bug when the check-in is done, and change it to the verified1.8.1.1 keyword after successful testing.

Thanks and sorry again for not fixing this right myself the first time.

Comment 14

[A S Alam]

Thanks Axel,
I have commited changes to CVS and added keyword.

Comment 15

[Axel Hecht [:Pike]]

[mass-verified1.8.1.1 message, filter on this if you need to]

This bug has an approved patch, but not the verified1.8.1.1 keyword.

Please make sure that the approved patch is landed (add the fixed1.8.1.1 keyword then) and tested. If you verified that the bug in question is indeed fixed on the 1.8 branch nightlies, please add the verified1.8.1.1 keyword.

We need to get the QA activities around Firefox 2.0.0.1 up to speed so that we can feel good about releasing this update.

Comment 16

[A S Alam]

tested with latest release and it is fixed.

thanks