353533 - Clicking Help in Change Action dialog doesn't bring up its help topic

Status: VERIFIED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Ton [:Tonnes]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/20060920 BonEcho/2.0
Build Identifier: 

Help button does not know there's a section about File types and directs to start page.

Reproducible: Always

Steps to Reproduce:
1. Tools > Options > Content
2. Click Manage, Change Action
3. Click Help

Actual Results:  
Taken to 'Welcome to Bon Echo Help' start page

Expected Results:  
Taken to File Types section

All Help/TOC links seem to be ok and working from other spots. Might have something to do with bug 347219 and/or moving this from Downloads to Content section?

Comment 1

[Ria Klaassen (not reading all bugmail)]

Happened on 13 September (trunk).

Comment 2

[Jeff Walden (gone starting June 8)]

I didn't think to search for ondialoghelp attributes:

http://lxr.mozilla.org/mozilla/search?string=dialoghelp

This is the only one that's broken, luckily.  We're probably past the time when changes can be made, but if we by some chance weren't, we'd readd a prefs-download-actions entry to firebird-toc.rdf (*not* changing existing help docs, just the RDF), let localizers know that the dangling pointer exists, and hope that at least some have time to fix it.

It's probably too late for this, but if there's to be any chance of this happening, we'd need the described patch ASAP.

Comment 3

[Steffen Wilberg]

So we need to change this line:
http://lxr.mozilla.org/mozilla1.8/source/browser/locales/en-US/chrome/help/firebird-toc.rdf#456

like this:
-<li><Description rdf:ID="prefs-file-types" nc:name="File Types" nc:link="prefs.xhtml#file_types"/></li>
<li><Description rdf:ID="prefs-download-actions" nc:name="File Types" nc:link="prefs.xhtml#file_types"/></li>

We don't use "prefs-file-types" anywhere:
http://lxr.mozilla.org/mozilla1.8/search?string=prefs-file-types
So we can change it to "prefs-download-actions" as needed by changeaction.xul:
http://lxr.mozilla.org/mozilla1.8/source/browser/components/preferences/changeaction.xul#52

Comment 4

[Steffen Wilberg]

This is a regression from bug 341899.

Comment 5

[Eric Shepherd [:sheppy]]

I can do up a patch for this pretty easily if we want to try to get it in at some point, although I assume we're not looking to do it for RC1.  Let me know.

Comment 6

[Steffen Wilberg]

Attachment: patch

I'd like to get this onto branch asap. RC2 is soon enough, provided that we do a RC2. ;-)

Comment 7

[Steffen Wilberg]

Fixed on trunk.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Marking blocking in case we need an RC2. CC'ing Axel to give us judgement on the l10n impact.

Comment 9

[Marek Stępień [:marcoos, inactive]]

Wouldn't it be better to actually change the id in changeaction.xul?

http://lxr.mozilla.org/mozilla1.8/source/browser/components/preferences/changeaction.xul#52

This way we won't break l10n's help, and don't need to update all the locales.

Changing IDs in firebird-toc requires all 50+ locales to port this change!

Comment 10

[Steffen Wilberg]

It breaks the locales who haven't updated to the prefwindow changes yet, or not completely:
http://lxr.mozilla.org/l10n-mozilla1.8/search?string=prefs-download-actions

Axel?

Comment 11

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #10)
> It breaks the locales who haven't updated to the prefwindow changes yet, or not
> completely:

Those without the prefwindow changes are already broken, now you're trying to break all the others as well.

http://lxr.mozilla.org/l10n-mozilla1.8/search?string=prefs-file-types

Comment 12

[Steffen Wilberg]

Attachment: alternate patch

OK, here's the alternate patch, which changes the .xul file instead of the help toc. I guess we should care more about the locales which are up-to-date with the new prefwindow documentation.

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 239531 [details] [diff] [review]
alternate patch

I'd rather go with this patch, and welcome a patch along this fixing the just the IDs in the affected help files. I could land that after this one to catch up.

Comment 14

[Steffen Wilberg]

Comment on attachment 239515 [details] [diff] [review]
patch

OK, I backed out the toc patch from trunk.

Comment 15

[Steffen Wilberg]

Attachment: patch for 16 out-of-date locales

Here's a patch replacing prefs-download-actions by prefs-file-types in the 16 locales which didn't catch up (fully) with the new prefwindow documentation.

Comment 16

[Axel Hecht [:Pike]]

Comment on attachment 239552 [details] [diff] [review]
patch for 16 out-of-date locales

Poke me on this, if you need a check-in buddy.

You want to post to .l10n, too, to announce that we're catching up on this.

Comment 17

[Steffen Wilberg]

I checked in the patch for the 16 out-of-date locales on the 1.8 branch, so that they still work once the second patch is checked in.

Comment 18

[Mike Connor [:mconnor]]

Comment on attachment 239531 [details] [diff] [review]
alternate patch

r+a=me

Approved for RC2

Comment 19

[Asaf Romano (gone)]

1.8:
Checking in browser/components/preferences/changeaction.xul;
/cvsroot/mozilla/browser/components/preferences/changeaction.xul,v  <--  changeaction.xul
new revision: 1.7.2.3; previous revision: 1.7.2.2
done

Comment 20

[Steffen Wilberg]

Fixed on trunk as well.

Comment 21

[Tracy Walker [:tracy]]

Verified on Windows trunk 20061003, Windows FF2rc2 and mac BE 20060928