353580 - Feed Preview UI does not render correctly on http://www.engadget.com/rss.xml

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20060918 Firefox/2.0.

STR:

1. Set pref to show feed reader preview
2. Visit http://www.engadget.com/rss.xml.

Observe UI in screenshot that is forthcoming.

This is one of the top ten feeds on the web, so it has a bit of visibility (http://share.opml.org/rankings/)

Comment 1

[Marcia Knous [:marcia]]

Attachment: Screenshot of UI on Linux running FC5

Comment 2

[Marcia Knous [:marcia]]

I also see this on http://www.livejournal.com/stats/latest-rss.bml

Comment 3

[Robert Sayre]

Attachment: I can see this on trunk too, but if you make the window wide enough, it goes away.

Comment 4

[Robert Sayre]

Attachment: engadget_com_rss.xml

Comment 5

[Robert Sayre]

This looks fixable with a little CSS, unless it's related to the XUL-in-XHTML at the top. Mano?

Comment 6

[Asaf Romano (gone)]

Is this linux only? CCing myk

Comment 7

[Robert Sayre]

No, I get it on mac as well (see attachment 239462 [details]). It seems related to the huge images in the feed.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot showing problem on adot's blog

I see this on Linux (Ubuntu Dapper Drake) too.  And if I make my window narrow enough, I see it on Asa Dotzler's RSS 2.0 feed (http://weblogs.mozillazine.org/asa/index.xml) as well.

On the engadget feed, on the other hand, some widths work fine, while others don't.  As I make my window narrower, the yellow background alternately pops back into view and disappears.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot showing engadget problem on mac

I can reproduce on Mac as well, although I haven't been able to reproduce on Windows.  Here's a screenshot of the problem on the Mac.

Comment 10

[Boris Zbarsky [:bzbarsky]]

This is hitting bug 252241, as far as I can tell.  The div that contains all the content is 30000-some pixels tall, which overflows the signed 16-bit widget coordinates that get used all over.  And due to the use of border-radius, background drawing goes through FillPolygon, which doesn't ConditionRect...

At least that's consistent with what I see happening in PaintBackgroundWithSC and with the symptoms.

Comment 11

[Asaf Romano (gone)]

Attachment: the workaround

Comment 12

[Marcia Knous [:marcia]]

I don't see the problem on Windows either. The interesting thing is that when I initially reported the bug, I had all of the sites open in tabs in a regular size window - there was no resizing of the window. Each time I opened up the engadget feed on Linux I saw the screenshot I attached.

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 239559 [details] [diff] [review]
the workaround

r+a=me, please land ASAP

its too bad we can't do this dynamically, but we'll live.

Comment 14

[Mike Connor [:mconnor]]

this is Approved for RC2

Comment 15

[Asaf Romano (gone)]

1.8:
mozilla/browser/themes/pinstripe/browser/feeds/subscribe.css 1.1.2.13
mozilla/browser/themes/winstripe/browser/feeds/subscribe.css 1.1.2.14

Comment 16

[Asaf Romano (gone)]

FWIW, you don't see this on windows because I accidentally landed the winstripe portion of this patch on trunk as part of the new theme... (assuming you were testing trunk builds).

Comment 17

[Tracy Walker [:tracy]]

verified on Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1) Gecko/20060928 BonEcho/2.0

Asaf, should this be resolved fixed?

Comment 18

[Asaf Romano (gone)]

not yet, need to land this on trunk first.

Comment 19

[Asaf Romano (gone)]

mozilla/browser/themes/pinstripe/browser/feeds/subscribe.css 1.16