353662 - bookmarks feed should point to redirect, not the site

Status: VERIFIED FIXED

(Mozilla Localizations :: nb-NO / Norwegian Bokmål, defect)

Description

[Axel Hecht [:Pike]]

I misread the patch in bug 346549.

You weren't supposed to change the feed, the redirect was supposed to stay.

This should really be fixed for 2.0.

Comment 1

[Håvard Mork]

Attachment: bookmarks redirect fix for nn-NO

Comment 2

[Håvard Mork]

Attachment: bookmarks redirect fix for nb-NO

My bad, I should have picked up that info also.

Comment 3

[Axel Hecht [:Pike]]

Please use the approval1.8.1 flag instead of the approval-l10n flag, we're not really using the latter anymore.

Comment 4

[Mike Schroepfer]

Comment on attachment 239523 [details] [diff] [review]
bookmarks redirect fix for nn-NO

Approved for RC2 (nn-NO feeds URL).

Comment 5

[Mike Schroepfer]

Comment on attachment 239525 [details] [diff] [review]
bookmarks redirect fix for nb-NO

Approved for RC2 (nn-NO bookmarks URL).

Comment 6

[Håvard Mork]

Checked in on MOZILLA_1_8_BRANCH as of now.

Checking in bookmarks.html;
/l10n/l10n/nn-NO/browser/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.1.2.8; previous revision: 1.1.2.7
done

Checking in bookmarks.html;
/l10n/l10n/nb-NO/browser/profile/bookmarks.html,v  <--  bookmarks.html
new revision: 1.4.2.21; previous revision: 1.4.2.20

Comment 7

[Axel Hecht [:Pike]]

Confirmed the check-in via bonsai query, please test on an upcoming nightly and mark the bug VERIFIED, adding fixed1.8.1 keyword for now.

Comment 8

[Lasse Marøen]

Verified, using nb-NO build 20060925.