Consolidate usage of convertDate into common location

RESOLVED FIXED in Sunbird 0.5

Status

Calendar
Internal Components
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Matthew (lilmatt) Willis, Assigned: Joey Minta)

Tracking

Trunk
Sunbird 0.5
All
Mac OS X

Details

Attachments

(1 attachment)

5.03 KB, patch
Matthew (lilmatt) Willis
: first-review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
convertDate is defined identically in calEvent.js calTodo.js and calRecurrenceInfo.js

We should combine all uses into one location (a la calUtils.js)

(spinoff from bug 349788)
(Assignee)

Comment 1

11 years ago
Created attachment 248042 [details] [diff] [review]
do it

This is a pure code-maintenance bug, so there's not a lot to say here.  convertDate() doesn't seem to exist in calRecurrenceInfo.js anymore.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #248042 - Flags: second-review?(dmose)
Attachment #248042 - Flags: first-review?(lilmatt)
(Reporter)

Comment 2

11 years ago
Comment on attachment 248042 [details] [diff] [review]
do it

r=lilmatt
Attachment #248042 - Flags: first-review?(lilmatt) → first-review+

Comment 3

11 years ago
Comment on attachment 248042 [details] [diff] [review]
do it

r2=dmose
Attachment #248042 - Flags: second-review?(dmose) → second-review+
(Reporter)

Updated

11 years ago
Whiteboard: [needs checkin]
Target Milestone: Future → Sunbird 0.5
(Reporter)

Comment 4

11 years ago
Patch checked in on MOZILLA_1_8_BRANCH and trunk.

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Updated

11 years ago
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.