35372 - please rename Cookie Manager dialog to "Cookie & Image Manager"

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[sairuh (rarely reading bugmail)]

since the Cookie Manager also includes a tab where the user can control when
images appear from particular sites, could you please rename the dialog to
exhibit that functionality? something like Cookie & Image Manager would be fine.

eli/tever, would this be fine by you as well?

Comment 1

[Blake Ross]

I agree that the title of the manager should reflect the entirety of its 
contents, although I feel in general the manager is somewhat confusing.  I 
can't imagine most average users seeing a connection between cookies and 
images.  Then again, given the nature of the cookie manager and cookies 
themselves, I would assume that the average Joe won't be messing with his 
cookies.

So to sum up this pointless paragraph in which I brought up a point and then 
refuted it, YES I with sairuh about the dialog title, although replacing "and" 
with the ampersand might be a bit nicer.

Comment 2

[sairuh (rarely reading bugmail)]

vera, d'you have any additional opinions on this?

Comment 3

[Blake Ross]

Sorry bout spam, my suggestion should have been to replace the *ampersand* 
with "and", not the other way around (as I initially wrote).

Comment 4

[verah (gone)]

I agree that to most people there's no connection between managing cookies and 
managing images... how did these two things come to be combined? Perhaps if I 
understand the connection, I can help to come up with the right words.

Comment 5

[Stephen P. Morse]

Verah, don't bother coming up with the correct words.  This viewer is entered 
either via a cookie menu item or an image menu item.  I can test for which menu 
item was clicked and put up the appropriate title and start frame in each case.  
I intend to do that as soon as the m15 freeze is over.

Comment 6

[verah (gone)]

Thanks -- I'm not sure I could have found the right words for that one!

Comment 7

[Stephen P. Morse]

Fix checked in.  Changed files are CookieViewer.js and CookieViewer.properties.

Comment 8

[Blake Ross]

this is still a bit awkward though, since now the titlebar can say Cookie 
Manager (if you choose the cookie menu option), but the Image Sites tab is 
still there and clicking it won't change the titlebar. 

also, clicking on the Cookie menu item works fine (caption of titlebar 
is "Cookie Manager" as expected), but clicking the image menu item causes the 
titlebar to still read "Cookie Manager" (not "Image Manager" as expected, 
though the default tab is the image one).

Comment 9

[Stephen P. Morse]

Would you like me to change the titlebar dynamically depending on which tab you 
are viewing?

Comment 10

[Blake Ross]

Not sure if that would be confusing or not, verah what do you think?  

Still, should this be reopened? Clicking on the image manager in the menu still 
causes the titlebar to read "Cookie Manager."

Comment 11

[Eli Goldberg]

CC:ing Matt in case he has a few words to say. 

Comment 12

[sairuh (rarely reading bugmail)]

checked this using the 2000.04.13.10/09-m16 comm bits on mac, linux and winNT.
now when i select the View Image Sites/Stored Stored Cookies button in the
Prefs, the dialog contains the appropriate title. (ditto when selecting to
corresponding items from Tasks > Personal Managers...)

it would be cool to dynamically update the dialog title --but how feasible would
this be, on the 3 platforms? (am just curious.)

Comment 13

[Blake Ross]

hmm..what the heck happened to anything image-related in 2000041308?  the menu 
item has entirely disappeared, as had the image tab of the manager.

Comment 14

[Matthew T (active 1999-2002)]

I agree with BlakeR's original comment. There should be separate dialogs for 
cookies and for images. The reason these got put together in the first place is 
that they're implemented in roughly the same way -- a classic example of 
developer-centred (rather than user-centred) design. As an analogy, this is like 
putting bookmarks and the address book in the same window because they both 
happen to use the tree widget. Coming up with a name which somehow covers both 
(or changing the window title depending on which comes up first, which is an even 
worse idea -- how are you going to refer to the window in the user 
documentation?) is a salve, but not a cure.

It does make sense to put cookies and images in the same category in the prefs 
dialog -- since the prefs for each are extremely similar, and the similarity 
helps the user understand the method of configuration. But for the windows with 
the lists of blocked items (hmm, there you go, how about `Blocked Items' as a 
title?), it would make more sense to me to include the cookie stuff in the 
`Cookie Jar' window (as a tab, with the other tab being the list of stored 
cookies), and leave `Blocked Images & Media' in its own window.

Hopefully this whole problem will go away when there is a decent prefs dialog 
with support for URL-by-URL prefs, of which cookies and images will be a subset.

(Please excuse any incoherence, I'm tired.)

Comment 15

[sairuh (rarely reading bugmail)]

hokay, am gonna verify this particular issue --but pls do reopen another bug re:
having separate dialogs for cookies and images... blakeR & mpt's reasoning here
do make a lot of sense!

Comment 16

[Matthew T (active 1999-2002)]

Bug 40026 filed about making these separate dialogs.