Closed
Bug 353920
Opened 18 years ago
Closed 18 years ago
Add about:license to About Camino
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Camino1.5
People
(Reporter: alqahira, Assigned: alqahira)
Details
(Keywords: fixed1.8.1.1)
Attachments
(2 files)
502 bytes,
application/rtf
|
samuel.sidler+old
:
review+
mikepinkerton
:
superreview+
|
Details |
1.04 KB,
patch
|
Details | Diff | Splinter Review |
Per all the Mo* licensing discussion, about:license needs to be in About Camino so that people can find the license(s). This requires 3 new lines in Credits.rtf and a resize of the About Camino window--wherever that's defined--to accommodate the new set of lines (otherwise we have an unsightly scrollbox). I propose we put this below Mozilla Contributors: License: Type “about:license” in the Location bar.
Comment 1•18 years ago
|
||
(In reply to comment #0) > and a resize of the About Camino window--wherever that's defined--to > accommodate the new set of lines (otherwise we have an unsightly scrollbox). It's defined in AppKit; AFAIK the only way to control the size is to use a custom about panel. Why can't this just go in the ReadMe?
Assignee | ||
Comment 2•18 years ago
|
||
From Gerv, in bug 328563 comment 13: The MPL and other licences have language about making things like license terms and lists of contributors "prominent" or "easily accessible". People look for this stuff in Help | About; so IMO we do need a link from there to about:license. (and see also bug 339117; there's been no indication that Camino is exempt from the licensing-display requirements of the MPL) We've talked about making our own panel before (to make the canonical URL clickable *and* ensure it opens in Camino), but my bugzilla fu is weak today. Alternatively, we could stop thanking the mailing list and fit everything. ;)
Assignee | ||
Comment 3•18 years ago
|
||
This does the last option in the previous comment, removes the ML "thanks" and adds in about:license.
Attachment #242574 -
Flags: review?(samuel.sidler)
Assignee | ||
Comment 4•18 years ago
|
||
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → alqahira
Comment 5•18 years ago
|
||
Comment on attachment 242574 [details]
modified Credits.rtf
r=me
Mike, this change removes the mailing list from the About Camino window and adds an addition License entry so users can see what license we ship under outside of the dimmidge (which is the only place we list it besides the website right now).
Attachment #242574 -
Flags: superreview?(mikepinkerton)
Attachment #242574 -
Flags: review?(samuel.sidler)
Attachment #242574 -
Flags: review+
Assignee | ||
Comment 6•18 years ago
|
||
Comment on attachment 242574 [details] modified Credits.rtf See comment 2 for why we need to add about:license, btw.
Comment 7•18 years ago
|
||
Comment on attachment 242574 [details]
modified Credits.rtf
sr=pink
Attachment #242574 -
Flags: superreview?(mikepinkerton) → superreview+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [needs checkin]
Comment 8•18 years ago
|
||
Landed on trunk and MOZILLA_1_8_BRANCH.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Updated•18 years ago
|
Keywords: fixed1.8.1.1
Updated•18 years ago
|
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•