354010 - No error dialog when attempting to create multiple lists of the same name in separate address books

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Kirk Madera]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7

Cannot create multiple lists of the same name in seperate address books

Reproducible: Always

Steps to Reproduce:

1. Set up two address books.
2. Set up a list in the first address book.
3. Attempt to set up a list of the same name in the second address book.
4. OK button does nothing. Program does not crash, but wil not continue.
5. It should allow this, or at the very least, display a warning message.

Comment 1

[Kent James (:rkent)]

I can confirm this behaviour in TB 1.5.0.5 under Windows 2000.

Comment 2

[Mark Banner (:standard8)]

There should be an alert present somewhere.

Can you check the error or javascript console (under the Tools menu) and paste any errors that appear when pressing the ok button here please?

Comment 3

[Kirk Madera]

This is the error I get in the javascript console.

Error: gAddressBookBundle is not defined
Source File: chrome://messenger/content/addressbook/abMailListDialog.js
Line: 72

Comment 4

[Mark Banner (:standard8)]

Thanks for the error message.

The problem with not allowing mailing lists with the same name in separate address books is bug 170296.

The problem with no error message being produced is a valid bug on Thunderbird trunk (and branch I guess) which should be fixed (SeaMonkey does not have this bug).

So rather than duplicate this bug to bug 170296 and open another one, I'll change the title from:

Cannot create multiple lists of the same name in seperate address books

to

No error dialog when attempting to create multiple lists of the same name in seperate address books

I already have an idea as to how I want to fix this.

Comment 5

[Mark Banner (:standard8)]

Attachment: Fix v1

This fixes the regression from bug 279176 by porting that patch to TB - it turns out that abMailListDialog.js issn't forked but abCommon.js was, so I'd obviously missed that when I fixed it.

Comment 6

[Mark Banner (:standard8)]

Patch checked into trunk, bug is fixed (still awaiting branch approval).

Comment 7

[Scott MacGregor]

Comment on attachment 253220 [details] [diff] [review]
Fix v1

thanks Mark.

Comment 8

[Mark Banner (:standard8)]

Fix checked into 1.8 branch as well.