354017 - Home and Print buttons aren't centered

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Phil Ringnalda (:philor)]

Split off from bug 352782 - see attachment 238589 [details]

toolbarbutton.css gives .toolbarbutton-icon some -moz-margin-end (2px in gnomestripe, 6px in winstripe), to put some space between the icon and the label. Before the visual refresh hid all labels, it wasn't quite as obvious: there was too much space to the right of the home and forward buttons, but the house in perspective and the dropmarker hid it reasonably well. Now, not so much: hover Home or Print, and the icon is obviously off-center within the border.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Without labels, I don't see a need for space before them.

Comment 2

[Asaf Romano (gone)]

Comment on attachment 239879 [details] [diff] [review]
Fix v.1

We should use http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/toolbarbutton.xml#65 here (and in few other places), and fix the style rules in toolbarbutton.css, but this will do for now.

r=mano.

Comment 3

[Asaf Romano (gone)]

1.8:
mozilla/toolkit/themes/winstripe/help/help.css  1.12.2.10

Comment 4

[Steve England [:stevee]]

The 'Go forward one page' button also looks off-center as well.

Comment 5

[Steve England [:stevee]]

Meh, i should read the bugs more closely before commenting. Sorry!

Comment 6

[Tracy Walker [:tracy]]

verified with 2.0rc2 on Windows

Comment 7

[Asaf Romano (gone)]

mozilla/toolkit/themes/winstripe/help/help.css 1.18