Home and Print buttons aren't centered

RESOLVED FIXED in mozilla1.9alpha1

Status

defect
RESOLVED FIXED
13 years ago
3 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

({verified1.8.1})

Bug Flags:
blocking-firefox2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Split off from bug 352782 - see attachment 238589 [details]

toolbarbutton.css gives .toolbarbutton-icon some -moz-margin-end (2px in gnomestripe, 6px in winstripe), to put some space between the icon and the label. Before the visual refresh hid all labels, it wasn't quite as obvious: there was too much space to the right of the home and forward buttons, but the house in perspective and the dropmarker hid it reasonably well. Now, not so much: hover Home or Print, and the icon is obviously off-center within the border.
Posted patch Fix v.1Splinter Review
Without labels, I don't see a need for space before them.
Attachment #239879 - Flags: first-review?(mano)
Comment on attachment 239879 [details] [diff] [review]
Fix v.1

We should use http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/toolbarbutton.xml#65 here (and in few other places), and fix the style rules in toolbarbutton.css, but this will do for now.

r=mano.
Attachment #239879 - Flags: first-review?(mano)
Attachment #239879 - Flags: first-review+
Attachment #239879 - Flags: approval1.8.1?
Status: NEW → ASSIGNED
Whiteboard: [checkin needed]
Attachment #239879 - Flags: approval1.8.1? → approval1.8.1+
1.8:
mozilla/toolkit/themes/winstripe/help/help.css  1.12.2.10
Keywords: fixed1.8.1
Flags: blocking-firefox2? → blocking-firefox2-
The 'Go forward one page' button also looks off-center as well.
Meh, i should read the bugs more closely before commenting. Sorry!
verified with 2.0rc2 on Windows
mozilla/toolkit/themes/winstripe/help/help.css 1.18
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Toolkit → Seamonkey
You need to log in before you can comment on or make changes to this bug.