354198 - Print output shows all day events from day preceding the selected date range

Status: VERIFIED FIXED

(Calendar :: Printing, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.7) Gecko/20060909 Firefox/1.5.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060925 Calendar/0.3a2+

When I create event with daily repeating and want to print it preview contains occurrence from previous day

Reproducible: Always

Steps to Reproduce:
1. create event from monday to frinday, daily repeating
2. print only wednesday
Actual Results:  
repeating event is printed twice even if you choose one day to print

Expected Results:  
occurrence from previous day should not be printed

Comment 1

[Damian Szczepanik]

Attachment: screenshot

one day to print but on preview you can see event twice

Comment 2

[Damian Szczepanik]

Event which I wanted to print:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.1//EN
BEGIN:VEVENT
CREATED:20060925T220049Z
LAST-MODIFIED:20060925T220049Z
DTSTAMP:20060925T220049Z
SUMMARY:all day
RECURRENCE-ID;VALUE=DATE;TZID=/mozilla.org/20050126_1/Africa/Ceuta:
 20060927
DTSTART;VALUE=DATE;TZID=/mozilla.org/20050126_1/Africa/Ceuta:20060927
DTEND;VALUE=DATE;TZID=/mozilla.org/20050126_1/Africa/Ceuta:20060928
END:VEVENT
BEGIN:VTIMEZONE
TZID:/mozilla.org/20050126_1/Africa/Ceuta
X-LIC-LOCATION:Africa/Ceuta
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=3
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

Comment 3

[Matthew (lilmatt) Willis]

This is another manifestation of bug 349788.
It's already been fixed in CVS.

*** This bug has been marked as a duplicate of 349788 ***

*** This bug has been marked as a duplicate of 349788 ***

Comment 4

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060926 Calendar/0.3a2+

Comment 5

[Stefan Sitter [:ssitter]]

I think this is not related to Bug 349788 because I can confirm using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060926 Calendar/0.3a2+.

You don't need repeating event to confirm this issue, a non-repeating all-day event is enough. Print output for e.g. 26-Sep-2006 also shows all-day event that ends on 25-Sep-2006.

I think this is a similar issue as in Bug 306157 that is worked on by Bug 333363.

Comment 6

[Joey Minta]

Attachment: memory bug

This is a bug in the memory provider, that was causing Bug 333363.  Rather than hacking like Bug 306157, I've gone for the full fix here.  We should probably be able to back out the Bug 306157 hack after this lands.

Comment 7

[Matthew (lilmatt) Willis]

Comment on attachment 246544 [details] [diff] [review]
memory bug

>Index: calendar/providers/memory/calMemoryCalendar.js
>===================================================================
>-                } else if (itemEndTime >= startTime) {
>+                } else if (itemEndTime > startTime  ||
>+                          (!item.endDate.isDate && itemEndTime == startTime)) {
>                     itemsFound.push(item);
>                 }

I feel like the first comparison (before the or) should be in parens. This would also let you remove the extra space before the ||.

It's up to you, but either way please remove that extra space.

r=lilmatt with that.

If this fixes the problem, we should back out the patch in bug 306157 and see if that bug reappears in the hourly.

Comment 8

[Joey Minta]

Comment on attachment 246544 [details] [diff] [review]
memory bug

This is wrong.  It won't work for tasks.

Comment 9

[Joey Minta]

Re-assigning my bugs to [e-mail] due to recent developments.

Comment 10

[Stefan Sitter [:ssitter]]

Issue still reproducible using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070906 Calendar/0.7pre.

Comment 11

[Sebastian Schwieger]

Attachment: fix memory provider

This fixes it for memory calendars, the bug still occurs for storage calendars. I'm unsure whether I should also check for events that have no start date - it should be invalid, right?
As a side note: reusing calUtils' checkIfInRange() does not work since tasks with no start date get assigned START_OF_TIME rather than its due date. I don't feel confident enough to change that.

I can't think of an easy fix for the storage calendar, yet. Hints welcome.

Comment 13

[Daniel Boelzle [:dbo]]

Comment on attachment 280513 [details] [diff] [review]
fix memory provider

Patch doesn't fix the problem for recurring all-day items.

Comment 14

[Daniel Boelzle [:dbo]]

This bug shows we have incorrect filtering in our providers, IMO similar to bug 333363. We need to resolve this for 0.8.

Comment 15

[Daniel Boelzle [:dbo]]

Damian, is this bug fixed with checkins for bug 333363?

Comment 16

[Sebastian Schwieger]

Fixed by checkin of bug 333363.

Comment 17

[Andreas Treumann]

After bug 333363 is fixed and verified I mark this issue also VERIFIED.