Closed Bug 35427 Opened 25 years ago Closed 24 years ago

[SKINS] make the account wizard skinnable

Categories

(Core Graveyard :: Skinability, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sspitzer, Assigned: alecf)

References

Details

(Whiteboard: [nsbeta2-]fix in hand)

keeping track of all the skin work we need to do in mailnews.
adding keywords.
Keywords: beta2, skins
work to do that I know of: Identity panel: - convert tables to grid - convert html:input's to <textfields> - convert html:input type=checkbox to <checkbox> Server panel: - convert checkboxes and radio buttons - convert text fields - convert auto-hiding <html:div> trick to <html> Copy/Folder settings: - convert table to grid - convert popup trick to <menulist> (need to create new widget w/xbl) Outgoing/SMTP panel: - convert table to grid - convert checkboxes - convert text fields (note that I have already done this work in smtpEditOverlay.xul, and it's currently being used in the Advanced dialog)
Status: NEW → ASSIGNED
Target Milestone: --- → M17
oops, I misread this as account _manager_ not wizard.
Keywords: nsbeta2
Feature. Marking nsbeta2+ 5/16 per pdt.
Keywords: beta2
Whiteboard: [nsbeta2+]5/16
Plan is to complete skins work this week.
Whiteboard: [nsbeta2+]5/16 → 5/5 [nsbeta2+]5/16
Depends on: 39336
*** Bug 40826 has been marked as a duplicate of this bug. ***
phil to review skins work remaining. Putting on [NEED INFO] radar.
Whiteboard: 5/5 [nsbeta2+]5/16 → [NEED INFO]
sorry for lack of communication.. I need Ben Goodger to rewrite/rework the wizard manager to be skin-friendly in order for this to happen. I've considered doing it myself, but I've been busy.
Putting on [nsbeta2-] radar. Not critical to beta2. Putting on nsbeta3 keyword. We will get these in post beta2.
Keywords: nsbeta3
Whiteboard: [NEED INFO] → [nsbeta2-]
*** Bug 41660 has been marked as a duplicate of this bug. ***
*** Bug 41660 has been marked as a duplicate of this bug. ***
Blocks: 41789
I've been working on this, but there's still many inconsistencies that need to be fixed between nsWidgetStateManager and the old widgetStateManager that are making this very, very difficult...
Component: Mail Window Front End → Skinability
Product: MailNews → Browser
QA Contact: lchiang → BlakeR1234
->skinability
->skinability
I had a brainstorm last weekend and came up with a really easy way to make this happen. I have the fix in my tree. renominating for nsbeta2 because this is such a high-visibility dialog and is part of the first 5 minutes of experience with mail. If you've ever created an account, you know how ugly this dialog is.. and it looks even uglier if you're using any other skin than modern...
Whiteboard: [nsbeta2-]
Whiteboard: fix in hand
wow....cool. Mind sharing what you did so I know what I was missing?
I just checked in aw-wizardAdapter.js into the tree to fix another bug - that's the glue code that connects everything together, all I basically had to do was - convert to XUL widgets - add wsm_persist="true" to each one - include aw-wizardAdapter.js in each page.
Putting on [nsbeta2-] radar. Not critical to beta2. Adding "nsbeta3" keyword for consideration of a fix for that milestone.
Summary: [SKINS] make the account wizard skinnable → [nsbeta2-][SKINS] make the account wizard skinnable
moving nsbeta2- designation to status, not summary.
Summary: [nsbeta2-][SKINS] make the account wizard skinnable → [SKINS] make the account wizard skinnable
Whiteboard: fix in hand → [nsbeta2-]fix in hand
this is finally, ever so finally fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Works for Me Platform: PC OS: Windows 98 Mozilla Version: 2000100508 Marking as Verified
Status: RESOLVED → VERIFIED
Keywords: skins
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.